Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Render multilayer symbols #269

Merged
merged 24 commits into from
Sep 26, 2023
Merged

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Render multilayer symbols in Visualization category.
URL to README: ReadME

Linked Issue(s)

  • swift/issues/4542

Screenshots

render-multilayer-symbols

@CalebRas CalebRas requested a review from a team September 19, 2023 22:08
@CalebRas CalebRas self-assigned this Sep 19, 2023
@CalebRas CalebRas requested review from philium, njarecha and zkline101 and removed request for a team and philium September 19, 2023 22:08
@CalebRas
Copy link
Contributor Author

Removed philium as a reviewer.

@CalebRas CalebRas changed the base branch from main to v.next September 22, 2023 21:59
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just few suggestions.

CalebRas and others added 2 commits September 26, 2023 10:34
Co-authored-by: Nimesh Jarecha <njarecha@esri.com>
njarecha
njarecha previously approved these changes Sep 26, 2023
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@CalebRas CalebRas dismissed stale reviews from zkline101 and njarecha via 4ed7b53 September 26, 2023 18:19
…lsView.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
zkline101
zkline101 previously approved these changes Sep 26, 2023
@CalebRas CalebRas merged commit 8cb2b9e into v.next Sep 26, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-RenderMultilayerSymbols branch September 26, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants