-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Render multilayer symbols #269
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed philium as a reviewer. |
zkline101
reviewed
Sep 25, 2023
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Zachary A Kline <zkline@esri.com>
njarecha
requested changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just few suggestions.
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Nimesh Jarecha <njarecha@esri.com>
njarecha
previously approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
zkline101
previously approved these changes
Sep 26, 2023
Shared/Samples/Render multilayer symbols/RenderMultilayerSymbolsView.swift
Outdated
Show resolved
Hide resolved
…lsView.swift Co-authored-by: Zachary A Kline <zkline@esri.com>
zkline101
previously approved these changes
Sep 26, 2023
njarecha
approved these changes
Sep 26, 2023
zkline101
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Render multilayer symbols
inVisualization
category.URL to README: ReadME
Linked Issue(s)
swift/issues/4542
Screenshots