Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Style symbols from mobile style file #272

Merged
merged 22 commits into from
Sep 27, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Style symbols from mobile style file in Visualization category.
URL to README: README

Linked Issue(s)

  • swift/issues/4072

How To Test

  • Tap "Symbol" create an emoji face by selecting a symbol for each category and adjusting the color/size.
  • Tap on the map to add the emoji to map.
  • Tap "Clear" to remove all the emojis from the map.

Screenshots

style-symbols-from-mobile-style-file-1 style-symbols-from-mobile-style-file-2

@CalebRas CalebRas requested review from a team, rolson and dfeinzimer and removed request for a team September 21, 2023 23:43
@CalebRas CalebRas self-assigned this Sep 21, 2023
CalebRas and others added 2 commits September 22, 2023 15:37
…lsFromMobileStyleFileView.SymbolOptionsListView.swift

Co-authored-by: R Olson <rolson@esri.com>
Copy link
Contributor

@rolson rolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Couple minor suggestions

dfeinzimer
dfeinzimer previously approved these changes Sep 26, 2023
Copy link
Contributor

@rolson rolson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@CalebRas CalebRas merged commit e253178 into v.next Sep 27, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-StyleSymbolsFromMobileStyleFile branch September 27, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants