-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Style symbols from mobile style file #272
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebRas
requested review from
a team,
rolson and
dfeinzimer
and removed request for
a team
September 21, 2023 23:43
rolson
reviewed
Sep 22, 2023
...mbols from mobile style file/StyleSymbolsFromMobileStyleFileView.SymbolOptionsListView.swift
Outdated
Show resolved
Hide resolved
...mbols from mobile style file/StyleSymbolsFromMobileStyleFileView.SymbolOptionsListView.swift
Outdated
Show resolved
Hide resolved
...mbols from mobile style file/StyleSymbolsFromMobileStyleFileView.SymbolOptionsListView.swift
Outdated
Show resolved
Hide resolved
...mbols from mobile style file/StyleSymbolsFromMobileStyleFileView.SymbolOptionsListView.swift
Outdated
Show resolved
Hide resolved
…lsFromMobileStyleFileView.SymbolOptionsListView.swift Co-authored-by: R Olson <rolson@esri.com>
dfeinzimer
previously approved these changes
Sep 25, 2023
Shared/Samples/Style symbols from mobile style file/StyleSymbolsFromMobileStyleFileView.swift
Outdated
Show resolved
Hide resolved
…lsFromMobileStyleFileView.swift Co-authored-by: David Feinzimer <dfeinzimer@gmail.com>
rolson
reviewed
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Couple minor suggestions
Shared/Samples/Style symbols from mobile style file/StyleSymbolsFromMobileStyleFileView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Style symbols from mobile style file/StyleSymbolsFromMobileStyleFileView.swift
Outdated
Show resolved
Hide resolved
dfeinzimer
previously approved these changes
Sep 26, 2023
rolson
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice!
dfeinzimer
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Style symbols from mobile style file
inVisualization
category.URL to README: README
Linked Issue(s)
swift/issues/4072
How To Test
Screenshots