Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] Show mobile map package expiration date #273

Merged
merged 10 commits into from
Sep 26, 2023
Merged

[New] Show mobile map package expiration date #273

merged 10 commits into from
Sep 26, 2023

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Show mobile map package expiration date in Maps category.
URL to README: README

Linked Issue(s)

  • swift/issues/4566

How To Test

  • Open the sample to view the expiration date and message.

Screenshots

show-mobile-map-package-expiration-date

To Discuss

  • I deviated from legacy iOS design and didn't include a timer since doing so distracts from the point of the sample and .Net, Java, Qt have similar implementations.

@CalebRas CalebRas requested a review from a team September 22, 2023 22:10
@CalebRas CalebRas self-assigned this Sep 22, 2023
@CalebRas CalebRas requested review from pgruenler and zkline101 and removed request for a team September 22, 2023 22:10
@CalebRas CalebRas merged commit 5780615 into v.next Sep 26, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-ShowMobileMapPackageExpirationDate branch September 26, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgruenler pgruenler pgruenler approved these changes

@zkline101 zkline101 zkline101 approved these changes

Assignees

@CalebRas CalebRas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@CalebRas @pgruenler @zkline101