-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Display dimensions #279
Conversation
I am not super happy with the design/implementation of the settings, but I couldn't find anything better since it you can't use toggles within a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
The settings is same as old sample . The design does not have the |
Co-authored-by: Nimesh Jarecha <njarecha@esri.com>
I went with the overlay design that Nimesh suggested since the implementation is much simpler, has better backwards compatibility, and doesn't distract from the topic of the sample like the "Settings" button implementation did. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. couple minor suggestions
Co-authored-by: R Olson <rolson@esri.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one suggestion.
Co-authored-by: Nimesh Jarecha <njarecha@esri.com>
Description
This PR implements
Display dimensions
inLayers
category.URL to README: README
Linked Issue(s)
swift/issues/4586
How To Test
Screenshots