[New] Show result of spatial relationships #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yo1995
reviewed
Jun 21, 2022
Comment on lines
50
to
54
| private var pointGraphic: Graphic { graphicsOverlay.graphics.last! } | ||
| /// The polyline graphic. | ||
| private var polylineGraphic: Graphic { graphicsOverlay.graphics[1] } | ||
| /// The polygon graphic. | ||
| private var polygonGraphic: Graphic { graphicsOverlay.graphics.first! } |
There was a problem hiding this comment.
Suggested change
| private var pointGraphic: Graphic { graphicsOverlay.graphics.last! } | |
| /// The polyline graphic. | |
| private var polylineGraphic: Graphic { graphicsOverlay.graphics[1] } | |
| /// The polygon graphic. | |
| private var polygonGraphic: Graphic { graphicsOverlay.graphics.first! } | |
| private var pointGraphic: Graphic { graphicsOverlay.graphics[2] } | |
| /// The polyline graphic. | |
| private var polylineGraphic: Graphic { graphicsOverlay.graphics[1] } | |
| /// The polygon graphic. | |
| private var polygonGraphic: Graphic { graphicsOverlay.graphics[0] } |
😂 I'm not sure if it's the way to go, but using all subscripts make more sense to me.
There was a problem hiding this comment.
I think using first and last is more swifty and safer even though we are force unwrapping in this case.
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Outdated
Show resolved
Hide resolved
yo1995
previously approved these changes
Jun 21, 2022
yo1995
previously approved these changes
Jun 23, 2022
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Outdated
Show resolved
Hide resolved
yo1995
previously approved these changes
Jun 23, 2022
zkline101
reviewed
Jun 28, 2022
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Show resolved
Hide resolved
Shared/Samples/Show result of spatial relationships/ShowResultOfSpatialRelationshipsView.swift
Show resolved
Hide resolved
zkline101
previously approved these changes
Jun 30, 2022
|
Looks good with the changes. Please resolve the conflict and I'll approve again. |
yo1995
approved these changes
Jul 11, 2022
zkline101
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Show result of spatial relationshipsinGeometrycategory.URL to README: URL
Linked Issue(s)
common-samples/issues/3627How To Test
Screenshots
To Discuss
Callout
How the information in the callout is shown could probably be improved. Maybe the addition of a divider could be nice; however, I would then have to specify a frame for the callout as the divider expands the width of the view.