Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Identify KML features #282

Merged
merged 14 commits into from
Oct 10, 2023
Merged

[New] Identify KML features #282

merged 14 commits into from
Oct 10, 2023

Conversation

CalebRas
Copy link
Contributor

@CalebRas CalebRas commented Oct 6, 2023

Description

This PR implements Identify KML features in Layers category.
URL to README: README

Linked Issue(s)

  • swift/issues/4599

How To Test

Screenshots

identify-kml-features

To Discuss

  • Note: The NSAppTransportSecurity key had to be added to the Info.plist in order to get the KML layer's legend to load. This is due to the link to the image being http instead of https.

@CalebRas CalebRas self-assigned this Oct 6, 2023
@CalebRas CalebRas requested review from a team, philium, yo1995, rolson and des12437 and removed request for a team, philium and yo1995 October 6, 2023 23:06
@CalebRas
Copy link
Contributor Author

CalebRas commented Oct 6, 2023

Removed yo1995 and philium as reviewers.

@des12437
Copy link
Contributor

des12437 commented Oct 9, 2023

Can padding be added to the legend with the types of sever weather so the entire text is visisble?

@CalebRas
Copy link
Contributor Author

CalebRas commented Oct 9, 2023

Can padding be added to the legend with the types of sever weather so the entire text is visisble?

I don't believe so. The text in the image itself is cut off. The iOS version had the same problem. I could download the image manually and overlay it on top of the map with padding, and that would prevent the bottom of the legend from being cut off by the map's attribution bar. The text at the top would still be cut off, though.

@des12437
Copy link
Contributor

des12437 commented Oct 9, 2023

Can padding be added to the legend with the types of sever weather so the entire text is visisble?

I don't believe so. The text in the image itself is cut off. The iOS version had the same problem. I could download the image manually and overlay it on top of the map with padding, and that would prevent the bottom of the legend from being cut off by the map's attribution bar. The text at the top would still be cut off, though.

It looks like the image was full sized when the sample was designed. Since the image has been updated I think it's okay to leave as-is.

Co-authored-by: Destiny Hochhalter <117859673+des12437@users.noreply.github.com>
des12437
des12437 previously approved these changes Oct 9, 2023
Shared/Samples/Identify KML features/README.md Outdated Show resolved Hide resolved
iOS/Info.plist Outdated Show resolved Hide resolved
@CalebRas CalebRas requested a review from rolson October 9, 2023 21:31
@CalebRas CalebRas merged commit 30e3bd2 into v.next Oct 10, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-IdentifyKMLFeatures branch October 10, 2023 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants