Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Identify graphics #283

Merged
merged 12 commits into from
Oct 10, 2023
Merged

[New] Identify graphics #283

merged 12 commits into from
Oct 10, 2023

Conversation

CalebRas
Copy link
Contributor

@CalebRas CalebRas commented Oct 9, 2023

Description

This PR implements Identify graphics in Visualization category.
URL to README: README

Linked Issue(s)

  • swift/issues/4603

How To Test

  • Tap on the graphic to see the alert.

Screenshots

identify-graphics

@CalebRas CalebRas self-assigned this Oct 9, 2023
@CalebRas CalebRas requested review from a team, pgruenler and njarecha and removed request for a team October 9, 2023 19:22
njarecha
njarecha previously approved these changes Oct 10, 2023
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I had a couple questions.

pgruenler
pgruenler previously approved these changes Oct 10, 2023
njarecha
njarecha previously approved these changes Oct 10, 2023
@CalebRas CalebRas merged commit 474acca into v.next Oct 10, 2023
1 check passed
@CalebRas CalebRas deleted the Caleb/New-IdentifyGraphics branch October 10, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants