-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Geocode offline #288
Conversation
[Fix] Update README.md to correct image path typo
Ensure new line for sub-lists
Co-authored-by: Ting <tchen@esri.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Minor comments. I think ideally there would be some error reporting if (reverse) geocode fails. But no big deal either way. Nice sample
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My suggestion would still be moving the callout placement to the view, but OK if the other reviewers agree to keep it as-is. Other than that the changes look good.
Description
This PR implements
Geocode offline
inSearch and Query
category.URL to README: README
Linked Issue(s)
swift/issues/4643
How To Test
swift-toolkit-daily
to compile.Screenshots
To Discuss
.searchable(text:placement:prompt:suggestions:)
) because there is a bug in iOS 17 where the suggestions don't disappear when one is selected or when "Enter" is pressed, making them useless. Related Apple Developer Forum post here.