Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Add changes for callout in Add dynamic entity layer #292

Merged
merged 4 commits into from
Nov 3, 2023
Merged

[Update] Add changes for callout in Add dynamic entity layer #292

merged 4 commits into from
Nov 3, 2023

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Nov 2, 2023 •
edited

Description

This PR updates Add dynamic entity layer in Layers category.
URL to README

Linked Issue(s)

  • swift/issues/4688
  • common-samples/pull/3882

How To Test

  1. Run the sample, all existing features work
  2. Tap on a vehicle. A callout should display
  3. When the vehicle moves, the callout should follow along
  4. When the observations are purged, the callout should be dismissed

Screenshots

To Discuss

  • The default values for speed and heading are nan. Very occasionally it causes the callout subview to give a warning in the console

Bound preference SizePreferenceKey tried to update multiple times per frame.

If the default values are set to zero I don't see this warning. Shall we make them zero?

  • If I don't reset the placement when observations are purged, the callout would stay in the old place when new observations are generated. Thus I passed a binding to the settings view.

@yo1995 yo1995 self-assigned this Nov 2, 2023
@yo1995 yo1995 changed the title [Update] Add changes for callout. [Update] Add changes for callout in Add dynamic entity layer Nov 2, 2023
@yo1995 yo1995 marked this pull request as ready for review November 3, 2023 16:06
@yo1995 yo1995 requested review from a team, njarecha and CalebRas and removed request for a team November 3, 2023 16:07
CalebRas
CalebRas reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one comment.

Shared/Samples/Add dynamic entity layer/AddDynamicEntityLayerView.VehicleCallout.swift Outdated Show resolved Hide resolved
@yo1995 @CalebRas
Update Shared/Samples/Add dynamic entity layer/AddDynamicEntityLayerV…
712a485 
…iew.VehicleCallout.swift

Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
njarecha
njarecha approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@njarecha njarecha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yo1995 yo1995 merged commit 810d8ce into v.next Nov 3, 2023
@yo1995 yo1995 deleted the Ting/UpdateDynamicEntitySample branch November 3, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@njarecha njarecha njarecha approved these changes

@CalebRas CalebRas CalebRas approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yo1995 @njarecha @CalebRas