-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Find closest facility to multiple points #295
Merged
CalebRas
merged 9 commits into
v.next
from
Caleb/New-FindClosestFacilityToMultiplePoints
Nov 9, 2023
Merged
[New] Find closest facility to multiple points #295
CalebRas
merged 9 commits into
v.next
from
Caleb/New-FindClosestFacilityToMultiplePoints
Nov 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CalebRas
requested review from
a team,
pgruenler and
yo1995
and removed request for
a team
November 8, 2023 23:37
yo1995
reviewed
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM
Shared/Samples/Find closest facility to multiple points/README.md
Outdated
Show resolved
Hide resolved
...mples/Find closest facility to multiple points/FindClosestFacilityToMultiplePointsView.swift
Outdated
Show resolved
Hide resolved
...mples/Find closest facility to multiple points/FindClosestFacilityToMultiplePointsView.swift
Outdated
Show resolved
Hide resolved
...mples/Find closest facility to multiple points/FindClosestFacilityToMultiplePointsView.swift
Outdated
Show resolved
Hide resolved
...mples/Find closest facility to multiple points/FindClosestFacilityToMultiplePointsView.swift
Outdated
Show resolved
Hide resolved
...mples/Find closest facility to multiple points/FindClosestFacilityToMultiplePointsView.swift
Outdated
Show resolved
Hide resolved
pgruenler
requested changes
Nov 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I just saw one typo to fix.
Shared/Samples/Find closest facility to multiple points/README.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Ting <tchen@esri.com>
yo1995
approved these changes
Nov 9, 2023
pgruenler
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements
Find closest facility to multiple points
inRouting and Logistics
category.URL to README: README
Linked Issue(s)
swift/issues/4647
How To Test
Screenshots