Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Setup] Add Privacy Manifest #296

Merged
merged 3 commits into from
Nov 9, 2023
Merged

[Setup] Add Privacy Manifest #296

merged 3 commits into from
Nov 9, 2023

Conversation

zkline101
Copy link
Contributor

@zkline101 zkline101 commented Nov 9, 2023

Description

These are the things that need to be declared in the privacy manifest if we collect any of this info:

I only listed in the privacy manifest that we use course location for a qualified reason. I didn't see any other items we need to list, please confirm this as a part of reviewing this PR.

Here is the privacy report for the Samples:
Samples-PrivacyReport 2023-11-08 15-52-45.pdf

Linked Issue(s)

  • swift/issues/4177

@zkline101 zkline101 requested a review from yo1995 November 9, 2023 00:13
@zkline101 zkline101 self-assigned this Nov 9, 2023
@zkline101 zkline101 requested review from a team and des12437 and removed request for a team November 9, 2023 00:13
@yo1995 yo1995 changed the title Add Privacy Manifest [Setup] Add Privacy Manifest Nov 9, 2023
yo1995
yo1995 previously approved these changes Nov 9, 2023
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on a similar PR duckduckgo/iOS#1936 the format and the location where the manifest is added look good.

Shared/PrivacyInfo.xcprivacy Outdated Show resolved Hide resolved
@yo1995 yo1995 requested a review from dg0yal November 9, 2023 17:56
@zkline101
Copy link
Contributor Author

Thanks!

@zkline101 zkline101 merged commit 1589737 into v.next Nov 9, 2023
1 check passed
@zkline101 zkline101 deleted the zach/addPrivacyManifest branch November 9, 2023 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants