Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Project #32

Merged
merged 3 commits into from
Jun 29, 2022
Merged

[New] Project #32

merged 3 commits into from
Jun 29, 2022

Conversation

clee088
Copy link
Contributor

@clee088 clee088 commented Jun 24, 2022

Description

This PR implements Project in Geometry category.

URL to README: URL

Linked Issue(s)

  • common-samples/issues/3655

How To Test

  • Tap on the map and a callout will appear with the original and projected coordinates.

Screenshots

project

To Discuss

  1. The iOS sample added an outline to the point graphic's marker symbol. I omitted this as it seemed redundant and just increased the marker size.
  2. I added a banner at the top saying "Tap on the map." Its description could be more descriptive or removed entirely. Personally, when I opened the sample for the first time, without reading the README, I was a little confused at what was supposed to happen.
  3. Wasn't sure if there was a specific CoordinateFormatter that would fit for this sample, so I displayed the raw coordinates.

@clee088 clee088 changed the base branch from main to v.next June 24, 2022 21:19
@clee088 clee088 requested a review from yo1995 June 24, 2022 21:19
yo1995
yo1995 previously approved these changes Jun 26, 2022
@yo1995
Copy link
Collaborator

yo1995 commented Jun 26, 2022

I added a banner at the top saying "Tap on the map." Its description could be more descriptive or removed entirely. Personally, when I opened the sample for the first time, without reading the README, I was a little confused at what was supposed to happen.

I like this 👍

Copy link
Contributor

@zkline101 zkline101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just small doc comments, the code looks good!

Shared/Samples/Project/README.md Outdated Show resolved Hide resolved
Shared/Samples/Project/README.md Outdated Show resolved Hide resolved
Co-authored-by: Zachary A Kline <zkline@esri.com>
@clee088 clee088 merged commit 4dd3437 into v.next Jun 29, 2022
@clee088 clee088 deleted the clee/New-Project branch June 29, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants