Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] List spatial reference transformations #342

Merged
merged 17 commits into from
Feb 15, 2024

Conversation

CalebRas
Copy link
Contributor

@CalebRas CalebRas commented Feb 2, 2024

Description

This PR implements List spatial reference transformations in Edit and Manage Data category.
URL to README: README

Linked Issue(s)

  • swift/issues/4921

How To Test

  • Tap on a transformation to see the projected geometry update.
  • Tap "Suitable for Map Extent" limit the transformations to those that are appropriate for the current extent.
  • To add projection engine data:
    • Tap "Download Data" and the download button next to the latest release of the Projection Engine Data.
    • Unzip the downloaded data in Files.
    • Tap "Set Data Directory" in the sample.
    • Navigate INTO the unzipped Projection Engine Data directory and tap "Open".

NOTE: Adding projection engine data while on-simulator causes it to crash. This currently only works on-device.

Screenshots

list-spatial-reference-transformations

@CalebRas CalebRas self-assigned this Feb 2, 2024
@CalebRas CalebRas requested review from a team, yo1995 and zkline101 and removed request for a team February 2, 2024 00:58
@CalebRas CalebRas requested a review from yo1995 February 8, 2024 00:10
zkline101
zkline101 previously approved these changes Feb 8, 2024
Copy link
Contributor

@zkline101 zkline101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any luck with that simulator crash?

…ialReferenceTransformationsView.Model.swift

Co-authored-by: Zachary A Kline <zkline@esri.com>
@CalebRas
Copy link
Contributor Author

CalebRas commented Feb 8, 2024

Any luck with that simulator crash?

No not yet. I think it is something we are going to look into at a later date.

Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall

CalebRas and others added 2 commits February 12, 2024 12:00
@zkline101
Copy link
Contributor

Is there an issue submitted for the simulator crash?

@CalebRas
Copy link
Contributor Author

Is there an issue submitted for the simulator crash?

@zkline101 Yes, swift/issues/4979

@CalebRas
Copy link
Contributor Author

Thank you!

@CalebRas CalebRas merged commit f5bb230 into v.next Feb 15, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/New-ListSpatialReferenceTransformations branch February 15, 2024 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants