-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New] Navigate route with rerouting #347
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple comments.
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
…ReroutingView.Model.swift Co-authored-by: Phil Gruenler <pgruenler@esri.com>
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Show resolved
Hide resolved
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM! 👍 Thanks for writing this sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One minor suggestion.
Shared/Samples/Navigate route with rerouting/NavigateRouteWithReroutingView.Model.swift
Outdated
Show resolved
Hide resolved
…ReroutingView.Model.swift Co-authored-by: Phil Gruenler <pgruenler@esri.com>
Thanks for reviewing! |
Description
This PR implements
Navigate route with rerouting
inRouting and Logistics
category.URL to README: README
Linked Issue(s)
swift/issues/4922
How To Test
Screenshots