Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New] Navigate route with rerouting #347

Merged
merged 15 commits into from
Feb 27, 2024

Conversation

CalebRas
Copy link
Contributor

Description

This PR implements Navigate route with rerouting in Routing and Logistics category.
URL to README: README

Linked Issue(s)

  • swift/issues/4922

How To Test

  • Press play to start the routing.
  • Listen to the voice guidances as the directions update.
  • Observe how the route is recalculated when the simulation does not follow the suggested route.
  • Tap recenter to reposition the viewpoint.
  • Tap reset to start the simulation from the beginning.

Screenshots

navigate-route-with-rerouting

@CalebRas CalebRas self-assigned this Feb 20, 2024
@CalebRas CalebRas requested review from a team, pgruenler and yo1995 and removed request for a team February 20, 2024 22:22
Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a couple comments.

CalebRas and others added 2 commits February 22, 2024 18:08
…ReroutingView.Model.swift

Co-authored-by: Phil Gruenler <pgruenler@esri.com>
pgruenler
pgruenler previously approved these changes Feb 23, 2024
yo1995
yo1995 previously approved these changes Feb 26, 2024
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! 👍 Thanks for writing this sample.

pgruenler
pgruenler previously approved these changes Feb 27, 2024
Copy link
Contributor

@pgruenler pgruenler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One minor suggestion.

…ReroutingView.Model.swift

Co-authored-by: Phil Gruenler <pgruenler@esri.com>
@CalebRas
Copy link
Contributor Author

Thanks for reviewing!

@CalebRas CalebRas merged commit 7e508d6 into v.next Feb 27, 2024
1 check passed
@CalebRas CalebRas deleted the Caleb/New-NavigateRouteWithReroutingView branch February 27, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants