Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] Configure basemap style parameters #349

Merged
merged 7 commits into from
Mar 7, 2024
Merged

[New] Configure basemap style parameters #349

merged 7 commits into from
Mar 7, 2024

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Mar 7, 2024 •
edited

@yo1995 yo1995 self-assigned this Mar 7, 2024
@yo1995 yo1995 requested review from a team, rolson and des12437 and removed request for a team March 7, 2024 17:29
@rolson rolson requested review from CalebRas and removed request for rolson March 7, 2024 19:11
@rolson
Copy link
Contributor

rolson commented Mar 7, 2024

@CalebRas please review in-lieu of me. Thank you

CalebRas
CalebRas reviewed Mar 7, 2024
View reviewed changes
Copy link
Contributor

@CalebRas CalebRas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! Just a few suggestions, take them or leave them.

Shared/Samples/Configure basemap style parameters/ConfigureBasemapStyleParametersView.swift Show resolved Hide resolved
Shared/Samples/Configure basemap style parameters/ConfigureBasemapStyleParametersView.swift Outdated Show resolved Hide resolved
Shared/Samples/Configure basemap style parameters/README.md Outdated Show resolved Hide resolved
Shared/Samples/Configure basemap style parameters/README.md Outdated Show resolved Hide resolved
Shared/Samples/Configure basemap style parameters/README.md Outdated Show resolved Hide resolved
yo1995 and others added 2 commits March 7, 2024 13:19
@yo1995 @CalebRas
Apply suggestions from code review.
eb91b27 
Co-authored-by: Caleb Rasmussen <crasmussen@esri.com>
@yo1995
Update method name.
3678b55
@yo1995
Copy link
Collaborator Author

yo1995 commented Mar 7, 2024

Thanks!

@yo1995 yo1995 merged commit e0cefb4 into v.next Mar 7, 2024
1 check passed
@yo1995 yo1995 deleted the Ting/New-ConfigureBasemapParams branch March 7, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CalebRas CalebRas CalebRas approved these changes

@des12437 des12437 des12437 approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yo1995 @rolson @CalebRas @des12437