Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] Browse building floors #35

Merged
merged 5 commits into from
Jul 22, 2022
Merged

[New] Browse building floors #35

merged 5 commits into from
Jul 22, 2022

Conversation

clee088
Copy link
Contributor

@clee088 clee088 commented Jul 5, 2022

Description

This PR implements Browse building floors in Maps category.
URL to README: URL

Linked Issue(s)

  • common-samples/issues/3581

How To Test

  1. Select "Building L" from the list of facilities.
  2. Select and display each floor in the floor filter overlay in the bottom right.

Screenshots

browse-building-floors

To Discuss

@clee088 clee088 requested a review from yo1995 July 5, 2022 15:58
@clee088 clee088 self-assigned this Jul 5, 2022
yo1995
yo1995 previously approved these changes Jul 20, 2022
View reviewed changes
Copy link
Collaborator

@yo1995 yo1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The compact size class on horizontal has weird UI issues, especially when the keyboard is out, but that would be solved in the toolkit component IMO.

Shared/Samples/Browse building floors/README.md Outdated Show resolved Hide resolved
@mhdostal
Copy link
Member

The compact size class on horizontal has weird UI issues, especially when the keyboard is out, but that would be solved in the toolkit component IMO.

@yo1995 Please add a toolkit issue if there's something to be fixed there. Thanks!

@clee088 @yo1995
Avoid keyboard changing viewpoint
59f8ebe 
Co-authored-by: Ting Chen <tchen@esri.com>
@yo1995 yo1995 requested a review from mhdostal July 20, 2022 17:49
@clee088 clee088 merged commit ff6107d into v.next Jul 22, 2022
@clee088 clee088 deleted the clee/New-BrowseBuildingFloors branch July 22, 2022 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhdostal mhdostal mhdostal approved these changes

@yo1995 yo1995 yo1995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@clee088 @mhdostal @yo1995