Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Replace deprecated API presentationMode #52

Merged
merged 2 commits into from
Aug 17, 2022

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Aug 16, 2022

Description

This PR fixes presentationMode which is deprecated in iOS 16. Learned that from the BNR training. It is replaced by https://developer.apple.com/documentation/swiftui/environmentvalues/dismiss

Linked Issue(s)

How To Test

The view behaves the same as before - tap button to dismiss.

`presentationMode` is deprecated in iOS 16.
@yo1995 yo1995 self-assigned this Aug 16, 2022
vquach2404
vquach2404 previously approved these changes Aug 16, 2022
@yo1995 yo1995 requested a review from vquach2404 August 17, 2022 16:27
@yo1995 yo1995 merged commit c6f566a into v.next Aug 17, 2022
@yo1995 yo1995 deleted the Ting/Fix-updateDeprecatedAPI branch August 17, 2022 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants