Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Update] Change deprecated navigation methods #55

Merged
merged 1 commit into from
Aug 23, 2022
Merged

[Update] Change deprecated navigation methods #55

merged 1 commit into from
Aug 23, 2022

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Aug 23, 2022

Description

This PR updates the 2 deprecated methods in iOS 16

Also, confirmationAction placement is used to make the "Done" button bold automatically, and it makes more sense semantically.

Linked Issue(s)

How To Test

No visual changes.

@yo1995 yo1995 self-assigned this Aug 23, 2022
dfeinzimer
dfeinzimer approved these changes Aug 23, 2022
View reviewed changes
Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@yo1995 yo1995 merged commit 67d53b2 into v.next Aug 23, 2022
@yo1995 yo1995 deleted the Ting/Fix-deprecatedMethodsNavigation branch August 23, 2022 19:21
@yo1995 yo1995 moved this from In Progress to Done in SwiftUI Sample Viewer prototyping Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfeinzimer dfeinzimer dfeinzimer approved these changes

@vquach2404 vquach2404 vquach2404 approved these changes

Assignees

@yo1995 yo1995

Labels
None yet
Projects
SwiftUI Sample Viewer prototyping
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yo1995 @dfeinzimer @vquach2404