[Update] Code and UI #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Similar to `Set surface placement mode` implementation.
yo1995
commented
Aug 30, 2022
Shared/Samples/Create planar and geodetic buffers/CreatePlanarAndGeodeticBuffersView.swift
Show resolved
Hide resolved
|
Just as a general comment, I noticed the Floor Filter's site and facility picker is consuming almost the full screen in the "Browse building floors" sample. It may benefit from a frame modifier as in the toolkit sample. |
|
More general feedback: In "Display feature layers", this button seems a bit hard to read with the purple on gray.
"Set viewpoint rotation" has a black background here which might make this easier to read
|
dfeinzimer
reviewed
Sep 1, 2022
Issue logged at https://github.com/ArcGIS/arcgis-runtime-samples-swift/projects/1#card-85400948 . I find it quite hard to put a magenta-like color on a dark translucent material, needs more experiments. |
dfeinzimer
approved these changes
Sep 1, 2022
vquach2404
approved these changes
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the third and the last batch of feedback from Chris to fix various coding pattern and UI in the samples.
Linked Issue(s)
swift/issues/2302How To Test
It would be appreciated if you can go through each changed sample and do some ad-hoc test to see if they still work the same.