Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Update] Rename Display feature layers #88

Merged
merged 2 commits into from
Dec 2, 2022
Merged

Conversation

yo1995
Copy link
Collaborator

@yo1995 yo1995 commented Dec 1, 2022

Description

This PR renames Display feature layers to Add feature layers.

Linked Issue(s)

  • common-samples/issues/3809

How To Test

Sample still runs and the status check is green ✅

@yo1995 yo1995 self-assigned this Dec 1, 2022
Copy link
Collaborator

@mikewilburn mikewilburn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't test the sample itself, but all the renames LGTM. Thanks Ting

@yo1995 yo1995 requested review from dfeinzimer and removed request for vquach2404 December 2, 2022 23:19
@yo1995
Copy link
Collaborator Author

yo1995 commented Dec 2, 2022

Hey David, can you help verify this branch is still working as expected? Thanks.

Copy link
Contributor

@dfeinzimer dfeinzimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well

@yo1995 yo1995 merged commit 3e427b4 into v.next Dec 2, 2022
@yo1995 yo1995 deleted the Ting/Update-RenameSample branch December 2, 2022 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants