[Fix] Screenshot path for Project geometry
#96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized that I didn't check the image paths because they are populated from the actual file paths on disk into the metadata. But there is a case like this if the metadata is generated first, and later on the sample name is changed, the checker will miss the image names. I consider this as a lower risk edge case, so will fix when we need to do other stuff with the status checker. |
saratchandrakarumuri
approved these changes
Dec 7, 2022
|
Here is another occurrence of this situation: #151 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the path to the screenshot. Thanks @maryharvey !
preview: https://github.com/Esri/arcgis-maps-sdk-swift-samples/blob/Ting/Fix-Screenshot/Shared/Samples/Project%20geometry/README.md