Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review and remove or edit Utility* conformances #152

Closed
6 tasks done
dfeinzimer opened this issue Sep 27, 2022 · 1 comment
Closed
6 tasks done

Review and remove or edit Utility* conformances #152

dfeinzimer opened this issue Sep 27, 2022 · 1 comment
Assignees
@dfeinzimer

Comments

@dfeinzimer
Copy link
Collaborator

dfeinzimer commented Sep 27, 2022 •
edited
Loading

As mentioned in Swift PR 2548, the toolkit's extended conformance to Hashable, Equatable and Identifiable for UtilityElement here should be reviewed and edited or removed as "it doesn't match the documented semantics of the Equatable protocol".

It would probably be good to check all extended Utility* conformances.

Types under consideration:
@dfeinzimer dfeinzimer self-assigned this Sep 27, 2022
@dfeinzimer dfeinzimer mentioned this issue Oct 5, 2022
Merged
@dfeinzimer dfeinzimer changed the title Review and remove or edit UtilityElement conformances Review and remove or edit Utility* conformances Oct 5, 2022
@dfeinzimer dfeinzimer mentioned this issue Oct 12, 2022
Merged
@dfeinzimer
Copy link
Collaborator Author

dfeinzimer commented Nov 3, 2022 •
edited
Loading

See also Swift #3015, #3033

This was referenced Nov 8, 2022
Merged
Merged
This was referenced Nov 18, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dfeinzimer dfeinzimer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dfeinzimer