Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UtilityNamedTraceConfiguration extensions #169

Merged
merged 3 commits into from
Nov 14, 2022

Conversation

dfeinzimer
Copy link
Collaborator

Related #152

I looked at moving the Hashable and Identifiable conformances to the SDK level but found that doing so properly would require adding similar conformances to additional underlying types (e.g. UtilityTraceConfiguration).

The documentation for UtilityNamedTraceConfiguration states:

Applications can simply allow the user to choose from a set of named trace configurations that provide tracing capabilities.

From that description, I presume that identifying a UtilityNamedTraceConfiguration by its name property is suitable for user display and selection purposes.

@dfeinzimer dfeinzimer merged commit dd6aba3 into v.next Nov 14, 2022
@dfeinzimer dfeinzimer deleted the df/RemoveUtilityNamedTraceConfigurationExtensions branch November 14, 2022 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants