-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Compass
to use heading
#70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the added flexibility these changes bring. I would also support an automaticallyHides
modifier.
@mhdostal I added some more doc. Please let me know what you think! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
This PR refactors the
Compass
component to use a heading to determine the orientation of the compass needle The viewpoint-based approach is still supported using a separate initializer.For future consideration is whether
autoHide
should be a modifier. The way it is now, the default value lives in three places (in each of the initializers).