df/RefactorFloatingPanel

[dfeinzimer]

• Resolves Floating Panel height can be set larger than displayed height #15

• Adds support for bottom vertical alignment

• Moves width into the constructor

• Will add 2nd reviewer once Mark has approved the changes

[dfeinzimer]

@mhdostal I've applied some changes that pull out the width param and make FP act more like how we discussed on Slack:

Achieving this is still a bit wonky though as it requires the user to conditionally apply width and padding:

[mhdostal]

@dfeinzimer Can we move the .padding logic into the floating panel? That way the client won't need to deal with it but they can add extra padding if they like.

As for the width, can the client simply set the .frame(maxWidth:) and let the floating panel deal with the rest? Setting just the maxWidth, would still allow the FP to shrink for compact width and limit the max width for regular width size classes.

[dfeinzimer]

Moving padding internal is a good call. I also changed width as suggested but am using

.frame(maxWidth: horizontalSizeClass == .regular ? 360 : .infinity)

because the provided value (e.g. 360 here) may not be wide enough to fill the width even in compact environments.

[mhdostal]

Just the one thing.

[mhdostal]

@dfeinzimer Nice work! These are useful additions to the FP!

[philium]

This is what I see when I first open the example on an iPhone in portrait orientation:

Is that right? It seems odd that the floating panel would be taking up the whole screen. If I rotate to landscape and then back to portrait, then the floating panel takes up only half of the screen:

I'm guessing that's the intended behavior.

[dfeinzimer]

I'm guessing that's the intended behavior.

At the moment, yes, that's at least the expected behavior. This is actually pre-existing if you try it on v.next (minus the rotation piece).

I intend to look at this height behavior in a subsequent PR to add support for use cases where programatic control of height is needed, similar to how the active detents of a sheet can be changed.

[mhdostal]

I intend to look at this height behavior in a subsequent PR to add support for use cases where programatic control of height is needed, similar to how the active detents of a sheet can be changed.

Yes, this would be good. The original design for the Floating Panel in the Data Collection open-source app did not allow arbitrary heights, but predefined "modes" (aka, detents):

- the height of the panel would have three "modes"
    * "Summary" - the panel height would be constrained to only a few lines of text
    * "Half-height" - the panel is roughly 30-40% of the height of the available display (height is customizable)
    * "Full-height" - the panel is the full height of the display