Bug Fixes + Support for External Load Balancer #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shailesh91
commented
Sep 6, 2018
•
shailesh91
commented
- Get FQDN resolves Ip into standard PTR format, it should have resolved either to machine name or just returned an IP. (https://en.wikipedia.org/wiki/Reverse_DNS_lookup#IPv4_reverse_resolution)
- Portal Unregister resource encoding fixed to UTF8
- Server Upgrade Configuration, Windows Service Resource wasn't imported and one of the conditions failed due to type mismatch
- Deprecating Global SSL Certs. Making Node Level Certificates the Standard.
- Multiple SSL certs per machine with a target component (can specify multiple targets for the same certificate)
- Dividing Configure DSC Configuration file into Configure components, Federation and Registering SQL Server.
- Fixing the endpoint URLs output at end of the job
- Adding support for External Load Balancers
1. Get FQDN resolves Ip into standard PTR format, it should have resolved either to machine name or just returned an ip. (https://en.wikipedia.org/wiki/Reverse_DNS_lookup#IPv4_reverse_resolution) 2. Portal Unregister resource encoding fixed to UTF8 3. Server Upgrade Configuration, Windows Service Resource wasn't imported and one of the conditions failed due type mismatch
This was referenced Sep 13, 2018
Closed
nshampur
approved these changes
Sep 13, 2018
spitzerr
suggested changes
Sep 14, 2018
There was a problem hiding this comment.
@shailesh91 thanks for all this nice fixes. I like the new Default certificate handling.
About federation. I would prefer, to "hide" the Server Port on federation URL if it is 443 as it gives nicer URLs for the Services on this machine. It has to be considered in "ArcGISFederation Federate".
|
@spitzerr I will consider making the necessary changes to the federation resource. |
nshampur
approved these changes
Sep 17, 2018
Closed
added 5 commits
September 18, 2018 18:42
This was referenced Sep 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.