Merge pull request #129 from Esri/proper-externals

Set externals properly for UMD builds

demos/ago-node-cli/README.md

@@ -13,7 +13,7 @@ Like all the other demo apps, run `npm run bootstrap` from the root.
 ### Running
 If you use this demo as a starting point for your own command line package, you would publish it to npm, then on the target systems run `npm install <your-cli-package>`, and it would be available as a command.
 
-But, this is demo code, and thus the package is not "installed" via `npm install ...`, before we can call it as `ago <command> <query>` we need to run `npm link` in the `/demos/node-cli` folder. After you do that, the command should work.
+But, this is demo code, and thus the package is not "installed" via `npm install ...`, before we can call it as `ago <command> <query>` we need to run `npm link` in the `/demos/ago-node-cli` folder. After you do that, the command should work.
 
 Here is a post with information on creating node command line tools: [A Guide to Creating a NodeJs Command](https://x-team.com/blog/a-guide-to-creating-a-nodejs-command/)
 

demos/geocoder-browser/index.html

@@ -16,28 +16,28 @@ <h1>get to geocodin!</h1>
     </div>
     <div class="col-md-4">
         <p>
-            <button class="btn" id="metadata" role="button">get service info</button>
+            <button class="btn btn-default" id="metadata" role="button">get service info</button>
         </p>
 
         <p>
             <input id="geocodeInput" value="123 main st"></input>
-            <button class="btn" id="geocode" role="button">geocode an address</button>
+            <button class="btn btn-default" id="geocode" role="button">geocode an address</button>
         <p>
             <input id="suggestInput" value="World Tr"></input>
-            <button class="btn" id="suggest" role="button">get address suggestion</button>
+            <button class="btn btn-default" id="suggest" role="button">get address suggestion</button>
         </p>
 
         <p>
             <input id="reverseInput" value="{x:-118,y:34}"></input>
-            <button class="btn" id="reverse" role="button">determine address</button>
+            <button class="btn btn-default" id="reverse" role="button">determine address</button>
         </p>
 
         <p>
-            <a href="" class="btn" id="sign-in" role="button">Sign In</a><br>
+            <a href="" class="btn btn-default" id="sign-in" role="button">Sign In</a><br>
         </p>
 
         <p>
-            <button class="btn" id="bulk" role="button">geocode many addresses</button>
+            <button class="btn btn-default" id="bulk" role="button">geocode many addresses</button>
         </p>
     </div>
 </div>
@@ -118,7 +118,7 @@ <h1>get to geocodin!</h1>
       "OBJECTID": 2,
       "SingleLine": "1 World Way Los Angeles 90045"
     }];
-    arcgisRest.bulkGeocode(addresses, { authentication: auth })
+    arcgisRest.bulkGeocode({ authentication: auth, addresses })
     .then((response) => {
         console.log("bulkGeocode", response);
     })

rollup.config.umd.js

@@ -54,6 +54,7 @@ export default {
   context: "window",
   extend: true, // causes this module to extend the global specified by `moduleName`
   moduleName,
+  external: packageNames,
   globals,
   plugins: [
     typescript(),