fix(:bathtub:): ensure add/update/deleteFeatures dont pass extraneous…

… parameters and fix tests to introspect objects returned by promise AFFECTS PACKAGES: @esri/arcgis-rest-feature-service
Esri · Jul 5, 2018 · 8566860 · 8566860
1 parent b144d05
commit 8566860
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 6 deletions.
diff --git a/packages/arcgis-rest-feature-service/src/add.ts b/packages/arcgis-rest-feature-service/src/add.ts
@@ -76,6 +76,7 @@ export function addFeatures(
 
   // mixin, don't overwrite
   options.params.features = requestOptions.adds;
+  delete options.params.adds;
 
   return request(url, options);
 }
diff --git a/packages/arcgis-rest-feature-service/src/delete.ts b/packages/arcgis-rest-feature-service/src/delete.ts
@@ -79,6 +79,7 @@ export function deleteFeatures(
 
   // mixin, don't overwrite
   options.params.objectIds = requestOptions.deletes;
+  delete options.params.deletes;
 
   return request(url, options);
 }
diff --git a/packages/arcgis-rest-feature-service/src/update.ts b/packages/arcgis-rest-feature-service/src/update.ts
@@ -75,6 +75,7 @@ export function updateFeatures(
 
   // mixin, don't overwrite
   options.params.features = requestOptions.updates;
+  delete options.params.updates;
 
   return request(url, options);
 }
diff --git a/packages/arcgis-rest-feature-service/test/features.test.ts b/packages/arcgis-rest-feature-service/test/features.test.ts
@@ -111,9 +111,8 @@ describe("feature", () => {
           )
       );
       expect(options.method).toBe("POST");
-      expect(addFeaturesResponse.addResults[0].objectId).toEqual(1001);
-      expect(addFeaturesResponse.addResults[0].success).toEqual(true);
-      expect(options.method).toBe("POST");
+      expect(response.addResults[0].objectId).toEqual(1001);
+      expect(response.addResults[0].success).toEqual(true);
       done();
     });
   });
@@ -146,7 +145,7 @@ describe("feature", () => {
           )
       );
       expect(options.body).toContain("rollbackOnFailure=false");
-      expect(updateFeaturesResponse.updateResults[0].success).toEqual(true);
+      expect(response.updateResults[0].success).toEqual(true);
       done();
     });
   });
@@ -166,10 +165,10 @@ describe("feature", () => {
       expect(options.body).toContain("objectIds=1001");
       expect(options.body).toContain("where=1%3D1");
       expect(options.method).toBe("POST");
-      expect(deleteFeaturesResponse.deleteResults[0].objectId).toEqual(
+      expect(response.deleteResults[0].objectId).toEqual(
         requestOptions.deletes[0]
       );
-      expect(deleteFeaturesResponse.deleteResults[0].success).toEqual(true);
+      expect(response.deleteResults[0].success).toEqual(true);
       done();
     });
   });