Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add info about 'npm run c' to CONTRIBUTING.md #147

Closed
jgravois opened this issue Mar 4, 2018 · 3 comments
Closed

add info about 'npm run c' to CONTRIBUTING.md #147

jgravois opened this issue Mar 4, 2018 · 3 comments
Assignees

Comments

@jgravois
Copy link
Contributor

jgravois commented Mar 4, 2018

our changelog parser zeros in commit message formatting that is generated by the command npm run c to categorize chores, bug fixes, features and breaking changes.

we need to advertise this to new contributors (and old grizzly bears like @tomwayson)

@jgravois jgravois self-assigned this Mar 4, 2018
@tomwayson
Copy link
Member

so just for clarity, for a PR like #131, if I had run npm run c on the first commit, but then gotten feedback in review that required changes that would affect the message, the right thing to do would have been a rebase and squash and pushed to the same PR, right?

@tomwayson
Copy link
Member

Or an even better example: https://github.com/Esri/arcgis-rest-js/pull/115/commits - where other people have pulled the branch and made their own commits. In that case we still want to squash and push to get the right message, right?

@jgravois
Copy link
Contributor Author

jgravois commented Mar 4, 2018

i think that the fact that the changelog parser ignores the extra commits means that its less important to squash. either way though.

jgravois added a commit that referenced this issue Mar 30, 2018
jgravois added a commit that referenced this issue Apr 5, 2018
* chore(CONTRIBUTING): add info about commitizen

ISSUES CLOSED: #147

* /end bold

* noah has eagle 👀
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants