feat(groups): add createGroupNotification #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFFECTS PACKAGES: @esri/arcgis-rest-groups
jgravois
reviewed
Sep 10, 2018
| * @param requestOptions - Options for the request | ||
| * @returns A Promise that will resolve with the success/failure status of the request | ||
| */ | ||
| // see http://mediawikidev.esri.com/index.php/ArcGIS.com/User_Notifications |
There was a problem hiding this comment.
lets remove this link since its not on the public web.
| users?: string[]; | ||
| notificationChannelType: string; | ||
| clientId?: string; | ||
| silentNotification?: boolean; |
There was a problem hiding this comment.
can we supply a default channel?
notificationChannelType?: "push" | "email" | "builtin"
// ...
notificationChannelType: requestOptions.notificationChannelType || "email"| export interface IGroupNotificationRequestOptions | ||
| extends IGroupIdRequestOptions { | ||
| subject?: string; | ||
| message: string | object; |
There was a problem hiding this comment.
especially since the REST endpoint isn't docced yet, more info in the inline TypeDoc would go a long way.
/*
* subject of the notification. This only applies to email and builtin notifications. For the push notifications, subject/title is provided as a part of the message payload.
*/
subject?: string;
jgravois
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFFECTS PACKAGES:
@esri/arcgis-rest-groups