docs(:lock:): add docs to explain how UserSession works #325
Conversation
ISSUES CLOSED: #224
There was a problem hiding this comment.
Nice work, especially going the extra mile to add the retry demo!
I made a couple of suggestions, but we can merge as is and tweak over time.
I'll tack on a follow on commit in another PR that adds a vs IdentityManager section to address some of stuff I brought up in #316 and will add a link to the JSAPI integration demo.
docs/src/guides/node.md
Outdated
| @@ -26,5 +26,43 @@ request("https://www.arcgis.com/sharing/rest/info").then(response => { | |||
| console.log(response); | |||
| }); | |||
| ``` | |||
| Demo - [express](https://github.com/Esri/arcgis-rest-js/tree/master/demos/express) | |||
|
|
|||
| ## User Authentication | |||
There was a problem hiding this comment.
Wouldn't it be better to show app auth for node? Isn't that going to be more of the norm?
Or maybe show both?
|
|
||
| In the [Node.js](../node/) guide we explained how to instantiate a [`UserSession`](/arcgis-rest-js/api/auth/UserSession/) with hardcoded credentials. | ||
|
|
||
| ```js |
There was a problem hiding this comment.
I wouldn't even put this snippet in this page.
| redirectUri: redirect_uri + 'authenticate.html', | ||
| popup: true | ||
| }) | ||
| .then(function (session) { |
There was a problem hiding this comment.
is this .then() block even needed?
| clientId, | ||
| redirectUri: 'https://yourapp.com/authenticate.html' | ||
| }) | ||
| .then(session) { |
There was a problem hiding this comment.
is this .then() block even needed?
|
|
||
| ## Retrying requests | ||
|
|
||
| If you don't _know_ if a web request requires authentication, you can try it anonymously and call `ArcGISAuthError.retry()` if you encounter a `403/499`. |
There was a problem hiding this comment.
It might be best to move this whole description over to the README for this demo and just link there?
|
pushed a few more commits to:
|
ISSUES CLOSED: #224
first pass at some conceptual documentation that explains how to instantiate and work with a
UserSessionto access secure content.adds yet another browser demo to show how
ArcGISAuthError.retry()and OAuth 2.0 fit together without fun stuff like vue or pulling a serialized session from a cookie.