Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(users): add user invitation functions #350

Merged
merged 5 commits into from
Oct 8, 2018
Merged

Conversation

mjuniper
Copy link
Member

@mjuniper mjuniper commented Oct 8, 2018

AFFECTS PACKAGES:
@esri/arcgis-rest-common-types
@esri/arcgis-rest-users

AFFECTS PACKAGES:
@esri/arcgis-rest-common-types
@esri/arcgis-rest-users
*/
export function getUserInvitation(
id: string,
requestOptions: IUserRequestOptions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that all these operations require auth, my recommendation would be:

export interface IInvitationRequestOptions extends IUserRequestOptions {
  invitationId: "string"; // mandatory param with more explicit name
}

// same for accept/decline
export function getUserInvitation (
  requestOptions: IInvitationRequestOptions
)
const url = `${portalUrl}/community/users/${username}/invitations/${requestOptions.invitationId}`;

see #78 for more info. i still really need to write some CONTRIBUTOR doc for this.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 4c0fce1 on f/user-invitations into dd7a5ac on master.

@Esri Esri deleted a comment from coveralls Oct 8, 2018
@Esri Esri deleted a comment from coveralls Oct 8, 2018
@jgravois jgravois merged commit 243a518 into master Oct 8, 2018
@jgravois jgravois deleted the f/user-invitations branch October 8, 2018 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants