Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed regex to match in cases where Keep me signed in is checked #413

Merged
merged 1 commit into from
Nov 29, 2018
Merged

fixed regex to match in cases where Keep me signed in is checked #413

merged 1 commit into from
Nov 29, 2018

Conversation

gavinr
Copy link
Contributor

@gavinr gavinr commented Nov 29, 2018

closes #412

@gavinr gavinr requested a review from jgravois November 29, 2018 20:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 924f790 on gavinr:oauth-browser-regex into 9ee647b on Esri:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 924f790 on gavinr:oauth-browser-regex into 9ee647b on Esri:master.

jgravois
jgravois approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@jgravois jgravois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gavinr!

i should have caught this when we landed #143

@jgravois jgravois merged commit 80ee3e4 into Esri:master Nov 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgravois jgravois jgravois approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

oauth2-browser demo: "Sign In (with popup)" fails when "Keep me signed in" is checked
4 participants
@gavinr @coveralls @jgravois @gavinr-maps