feat(portal): new addGroupUsers() function #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AFFECTS PACKAGES: @esri/arcgis-rest-portal ISSUES CLOSED: #584
Codecov Report
@@ Coverage Diff @@
## master #585 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 93 95 +2
Lines 1366 1407 +41
Branches 245 248 +3
=====================================
+ Hits 1366 1407 +41
Continue to review full report at Codecov.
|
tomwayson
requested changes
Jun 17, 2019
| return request(url, requestOptions).catch(error => { | ||
| return { | ||
| // the request should either add users or admins, not both | ||
| notAdded: requestOptions.users || requestOptions.admins, |
There was a problem hiding this comment.
I don't think we should populate notAdded when there are errors. We don't want them to get mixed up w/ any that were not added b/c they were already in the group.
There was a problem hiding this comment.
I have updated the code
tomwayson
approved these changes
Jun 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #584