Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

set android support versions to binary equivalent androidx versions. #745

Merged
merged 2 commits into from Mar 11, 2020

Conversation

sorenoid
Copy link
Collaborator

same libraries, updated names.
com.android.support:appcompat-v7 v28.0.0 is androidx.appcompat:appcompat v1.0.0
and
com.android.support:design v28.0.0 is com.google.android.material:material v1.0.0

…see https://developer.android.com/jetpack/androidx/migrate/artifact-mappings

Testing across older android versions seems necessary. Sorry to say I am not quite sure how to go about that other than alerting Hardik, any thoughts @TADraeseke ?

Copy link
Contributor

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do this for kotlin/build.gradle too :)

@ZackAllen
Copy link

I am not familiar enough with the Android project or Gradle to give this a meaningful review.

@TADraeseke TADraeseke self-requested a review March 10, 2020 17:45
Copy link
Contributor

@TADraeseke TADraeseke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @sorenoid

@sorenoid sorenoid merged commit 6b40bfb into master Mar 11, 2020
@sorenoid sorenoid deleted the sor10874/1782-finish-androidx-migration branch March 11, 2020 17:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants