This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
Hud10837/display device location kotlin #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TADraeseke
suggested changes
Mar 10, 2020
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
kotlin/display-device-location/src/main/res/layout/activity_main.xml
Outdated
Show resolved
Hide resolved
kotlin/display-device-location/src/main/res/layout/activity_main.xml
Outdated
Show resolved
Hide resolved
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com>
|
@TADraeseke thanks for the thorough review! I've addressed those changes and it seems that I never added/committed the readme/metadata/png, so could you take a look at those as well? Thanks! |
TADraeseke
suggested changes
Mar 17, 2020
There was a problem hiding this comment.
Hey @hud10837! Looking pretty good! A few suggestions in line. Also, when I click on the location display list I see Navigation twice :)
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/SpinnerAdapter.kt
Outdated
Show resolved
Hide resolved
...location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/SpinnerAdapter.kt
Outdated
Show resolved
Hide resolved
kotlin/display-device-location/src/main/res/layout/spinner_layout.xml
Outdated
Show resolved
Hide resolved
kotlin/display-device-location/src/main/res/layout/spinner_layout.xml
Outdated
Show resolved
Hide resolved
kotlin/display-device-location/src/main/res/layout/spinner_layout.xml
Outdated
Show resolved
Hide resolved
Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com>
Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com>
|
@TADraeseke thanks for those, I've made the changes. Regarding seeing "Navigation" twice, is this only when you have selected the Navigation mode and look at the list again? If that's the case, I suppose the best fix would be to change the display of the currently selected mode somehow, as I imagine changing the way the list is displayed would be far more complicated. What do you think? |
TADraeseke
approved these changes
Mar 20, 2020
Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com>
|
Thanks Trevor, |
Rachael-E
reviewed
Mar 24, 2020
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Show resolved
Hide resolved
...location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/SpinnerAdapter.kt
Outdated
Show resolved
Hide resolved
|
Thanks @Rachael-E is that looking better now? |
Rachael-E
approved these changes
Mar 25, 2020
...e-location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/MainActivity.kt
Outdated
Show resolved
Hide resolved
...location/src/main/java/com/esri/arcgisruntime/sample/displaydevicelocation/SpinnerAdapter.kt
Show resolved
Hide resolved
|
Thanks, merging now! |
TADraeseke
added a commit
that referenced
this pull request
Apr 3, 2020
* Hud10837/display device location kotlin (#751) * initial file transfer * fix compiler errors * working sample * cleanup * move permissions check etc to separate function * add readme, screenshot, metadata and do checklist * add bg to spinner * move spinner above attribution bar * rename params for attributionviewlayoutchangelistener * close mapview tag Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * pr fixes * fix permissions request functionality * change v to view Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix mode typo Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * address pr fixes * fix readme numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove metadata whitespace * address pr comments * put periods back in Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Readme migration from common (#768) * identify kml features README for java android sample. * update read geopackage from review comments * remove unused class reference * identify kml features README with method names in relevant api for now. * IWA sample README update. * line of sight geoelement README update from common samples. offline data section removed because files are built into the app. * location line of sight README updated from common. * README updated for kotlin identify-layers from common * identify-layers java and kotlin, identify-kml-features, IWA, line of sight geoelement, and line of sight location READMES updated from common * add missing word to sentence. * remove method parentheses * List KML Contents sample README from common * List related features sample README from common * list transformations by suitability sample README from common * manage bookmarks README updated from common samples * manage operational layers README updated from common samples * whitespace * map image layer README migrated from common * change sublayer visibility README migrated from common * map image layer tables README migrated from common * Map Initial Area README migrated from common * map load status README migrated from common * whitespace * remove API from tags * remove API from tags * remove excess space * update how to use and how it works * remove comma * code review comments addressed * service feature table manual readme update * update about the data for current data used, and website links for android * update servicefeaturetable (cache) data and weblink * update set initial map location readme * update callout readme * click -> tap. Complete an incomplete sentence, and make usage more explicit. * click -> tap. Complete an incomplete sentence, and make usage more explicit. * update show labels on layer readme * update kotlin readme for data currently used * misused API methods fixed. Line of sight location usage reworded slightly. * kotlin update of identify-layers README.md * use consistent text and verbiage between the two line of sight samples * dont change name! * minor grammar fix * tweak transformation by suitability How it works section. * minor typo * tweak "How to use" section for indentify-layers * change IWA API classname * capitalization * sync java README to kotlin for identify-layers * README for map-reference-scale migrated from common. * README for map-rotation migrated from common. * README for set-map-spatial-reference migrated from common. * README for set-min-max-scale migrated from common. * README for mobile-map-search-and-route migrated from common. * README for navigate in AR migrated from common. part 1 * Revert "README updated for kotlin identify-layers from common" This reverts commit e35db38. * Update README.md * Revert "location line of sight README updated from common." This reverts commit 5e3afa2. * Revert "line of sight geoelement README update from common samples. offline data section removed because files are built into the app." This reverts commit b7f4c7f. * Revert "IWA sample README update." This reverts commit e736708. * Revert "identify kml features README with method names in relevant api for now." This reverts commit 96b58b5. * Revert "identify kml features README for java android sample." This reverts commit 185b480. * americanize centered * Readmes/change atmosphere to change viewpoint (#716) * change-atmosphere-effect * change-basemaps * changefeaturelayerrenderer * changesublayerrenderer * changeViewpoint * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove method call Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * update show magnifier readme * update simple marker symbol * update simple renderer readme * update sketch editor readme * update spatial relations readme * update statistical query readme * Update README.md * update stretch renderer readme * update style wms layer readme * update surface placement readme * self review improvements * change the name. * address review comments * specify java API from generic common API verbiage * specify java API from .net-like common API verbiage * rephrase a few sentences * sync java to kotlin identify-layers README * reference offline data section explicitly. * add offline data section. * fix up how it works section. * remove extraneous API listing. standardiza "How it works" pseudocode. * javafy the API usage in How it works * clean up a few sentences and API classes * fix up a few sentences * navogateroute README migrated from common. * offlinegeocode README migrated from common * openexistingmap aka OpenMapUrl README migrated from common * openmobilemappackage README migrated from common * openmobilescenepackage README migrated from common * open scene portal item README migrated from common * OpenStreetMap Layer README migrated from common * PerformWSpatialOperations java README migrated from common * PerformWSpatialOperations kotlin README migrated from common * PictureMarkerSymbols README migrated from common * play a kml tour README migrated from common * play a kml tour README migrated from common * slight rewrite. * address review comments * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * replace set with pass Co-Authored-By: sorenoid <sorenoid@gmail.com> * use java setter Co-Authored-By: sorenoid <sorenoid@gmail.com> * use setRasterRenderer Co-Authored-By: sorenoid <sorenoid@gmail.com> * instantiate an ArcGISMap improvement Co-Authored-By: sorenoid <sorenoid@gmail.com> * Readmes/densify to display drawing status (#729) * densify and dictionary * display annotation * location display * draw status * add period * start to startAsync * update symbolizeshapefile readme * update read symbols mobile readme * update take screenshot readme * update terrain exaggeration readme * update arcgistiledlayer readme * update time based query readme * update token authentication readme * update feature layer update attributes readme * revert back to useful how to use description * update feature layer update geometries readme * update update related features readme * revert image description * address review comments * removed extraneous API. provided a code example for How it works. * change name. Make download instructions more explicit. * make "How to use" more android UI specific. Use getter and setter terminology in How it works, rather than classnames. Other minor tweaks. * specify that controls are accessible through action bar button * turn quasi variable name into plain English. * fix run-on code style. change variable name * mention overflow menu * remove non android API * code example * Readmes/attributionviewchange to buffer (#712) * attributionviewchange * authenticate * blendrenderer * wfslayers * buffer * click to tap * change select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * make Tags less bold Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change method call to match java Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add full stop Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change layoutparams step description * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * change Map View to MapView Co-Authored-By: sorenoid <sorenoid@gmail.com> * remaining pr fixes Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> * Readmes/display grid to display map (#730) * displayGrid * displayKML * displayKMLNetwork * displayLayerViewState * displayMap * API name changes * kml readme fixes * layer view state changes * display map changes * remove nonexistant API * Readmes/create and save map to delete features (#724) * createAndSaveMap * createTerrainFromLocalRaster * createTerrainFromTilePackage * cutGeometry * deleteFeatures * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove backticks * fix ArcGISMap name * remove word * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove brackets on kotlin method calls * remove oauth note Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Readmes/display scene to distance measurement (#731) * displayScene * displaySceneInAR, displayWFS, distance composite symbol * distanceMeasurement * arView to mArView * fix API method names Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api method * FIX TYPOS Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix measurement changed callback references Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * improve grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * improve table and server update description * update vector tile basemaps readme * update beneath terrain readme * update view point cloud readme * update viewshed camera * update viewshed geoelement readme * minor improvements * refactor as optional comment * address review comments * update viewshedgeoprocessing readme * update viewshed location readme * update web tiled layer * update wfsxmlquery readme * update wms layer url * update wmts layer readme * change drop down to navigation Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * make imperative Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Readmes/choose camera controller to control annotation sublayer visibility (#717) * chooseCameraController * clipGeometry * colorMapRenderer * configureSubnetworkTrace * controlAnnotationSublayerVisibility * fix colormap-renderer grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix class reference name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix Domain reference Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove code tag from barriers Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change traceconfiguration name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove extra space Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * utility prefix * step 8 clarification * redo previous pr fixes Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * address review comments * make spatial operations example "How it works" more explicit. remove newline and redundant information, other minor changes. * more files for last commit * add period to end of new sentence. * Readmes/downloadprelanned to explore scenesin flyover (#732) * downloadPreplanned * editSyncFeatures * editFeatureAttachments * elevationAtPoint * exploreSceneInFlyoverAR * java to android links * edit and sync features changes * api method calls * clarify .start method Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove line of asterisks * remove unused instruction * remove article in title Co-authored-by: sorenoid <sorenoid@gmail.com> * improve readability Co-Authored-By: sorenoid <sorenoid@gmail.com> * shorten description * address review comments * Export tiles to feature layer dictionary renderer (#737) * exportTiles * featureCollectionLayer * FeatureCollectionLayerQuery * featureLayerDefinitionExpression * featureLayerDictionaryRenderer * fix typo Co-Authored-By: sorenoid <sorenoid@gmail.com> * add method call to api Co-Authored-By: sorenoid <sorenoid@gmail.com> * address PR changes * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add new keyword Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * lowercase instance name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * simplify instruction Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api from how to use * reword geometry type instruction * definition expression changes * and to or Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix portal user API usage and make grammar imperative. remove redundant step from play a kml tour. * fix up spatial operations "How to use the sample" to be more sprecific to the android implementations" * remove instruction that isn't sensible in the android app * fix up PortalUser kotlin version * two kotlin READMES i missed. * migrate java/create-geometries README from common * Readmes/feature layer extrusion to feature layer feature service (#738) * featureLayerExtrusion * featureLayerFeatureService * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove duplicates * pr changes * fix wording * fix extrusion api Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * changes to integrated windows auth kotlin README, also copied to the java version, and a small vraiable name change in set-min-max * update link to guide * remove mention of domain which we don't use in Java * Update java/openstreetmap-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/project/README.md * Update java/raster-function-service/README.md * Update java/raster-function-service/README.md * fixes (#771) * fixes * Update README.md * Missing readmes (#772) * integrated windows auth * integrated windows auth * set min max scale * unique value renderer * feautre layer show attributes * title casing * expand use case Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix method names Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix generate offline map how to use * Readme suggestions and comments (#776) * pr fixes * fixes * fixes * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Update java/animate-3d-graphic/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * Update java/buffer/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * remove returnDirections parameter instruction * Update java/viewshed-geoelement/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update java/add-enc-exchange-set/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/add-graphics-symbols/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/apply-scheduled-updates-to-preplanned-map-area/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/raster-function-service/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/token-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update README.md * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/export-tiles/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-query/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-show-attributes/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map-with-local-basemap/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/find-service-area-interactive/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/list-related-features/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/manage-operational-layers/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/offline-geocode/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/open-existing-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/read-geopackage/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/service-feature-table-cache/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/set-map-spatial-reference/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-callout/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-labels-on-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: hud10837 <60605708+hud10837@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com>
TADraeseke
added a commit
that referenced
this pull request
Apr 7, 2020
* Hud10837/display device location kotlin (#751) * initial file transfer * fix compiler errors * working sample * cleanup * move permissions check etc to separate function * add readme, screenshot, metadata and do checklist * add bg to spinner * move spinner above attribution bar * rename params for attributionviewlayoutchangelistener * close mapview tag Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * pr fixes * fix permissions request functionality * change v to view Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix mode typo Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * address pr fixes * fix readme numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove metadata whitespace * address pr comments * put periods back in Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Readme migration from common (#768) * identify kml features README for java android sample. * update read geopackage from review comments * remove unused class reference * identify kml features README with method names in relevant api for now. * IWA sample README update. * line of sight geoelement README update from common samples. offline data section removed because files are built into the app. * location line of sight README updated from common. * README updated for kotlin identify-layers from common * identify-layers java and kotlin, identify-kml-features, IWA, line of sight geoelement, and line of sight location READMES updated from common * add missing word to sentence. * remove method parentheses * List KML Contents sample README from common * List related features sample README from common * list transformations by suitability sample README from common * manage bookmarks README updated from common samples * manage operational layers README updated from common samples * whitespace * map image layer README migrated from common * change sublayer visibility README migrated from common * map image layer tables README migrated from common * Map Initial Area README migrated from common * map load status README migrated from common * whitespace * remove API from tags * remove API from tags * remove excess space * update how to use and how it works * remove comma * code review comments addressed * service feature table manual readme update * update about the data for current data used, and website links for android * update servicefeaturetable (cache) data and weblink * update set initial map location readme * update callout readme * click -> tap. Complete an incomplete sentence, and make usage more explicit. * click -> tap. Complete an incomplete sentence, and make usage more explicit. * update show labels on layer readme * update kotlin readme for data currently used * misused API methods fixed. Line of sight location usage reworded slightly. * kotlin update of identify-layers README.md * use consistent text and verbiage between the two line of sight samples * dont change name! * minor grammar fix * tweak transformation by suitability How it works section. * minor typo * tweak "How to use" section for indentify-layers * change IWA API classname * capitalization * sync java README to kotlin for identify-layers * README for map-reference-scale migrated from common. * README for map-rotation migrated from common. * README for set-map-spatial-reference migrated from common. * README for set-min-max-scale migrated from common. * README for mobile-map-search-and-route migrated from common. * README for navigate in AR migrated from common. part 1 * Revert "README updated for kotlin identify-layers from common" This reverts commit e35db38. * Update README.md * Revert "location line of sight README updated from common." This reverts commit 5e3afa2. * Revert "line of sight geoelement README update from common samples. offline data section removed because files are built into the app." This reverts commit b7f4c7f. * Revert "IWA sample README update." This reverts commit e736708. * Revert "identify kml features README with method names in relevant api for now." This reverts commit 96b58b5. * Revert "identify kml features README for java android sample." This reverts commit 185b480. * americanize centered * Readmes/change atmosphere to change viewpoint (#716) * change-atmosphere-effect * change-basemaps * changefeaturelayerrenderer * changesublayerrenderer * changeViewpoint * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove method call Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * update show magnifier readme * update simple marker symbol * update simple renderer readme * update sketch editor readme * update spatial relations readme * update statistical query readme * Update README.md * update stretch renderer readme * update style wms layer readme * update surface placement readme * self review improvements * change the name. * address review comments * specify java API from generic common API verbiage * specify java API from .net-like common API verbiage * rephrase a few sentences * sync java to kotlin identify-layers README * reference offline data section explicitly. * add offline data section. * fix up how it works section. * remove extraneous API listing. standardiza "How it works" pseudocode. * javafy the API usage in How it works * clean up a few sentences and API classes * fix up a few sentences * navogateroute README migrated from common. * offlinegeocode README migrated from common * openexistingmap aka OpenMapUrl README migrated from common * openmobilemappackage README migrated from common * openmobilescenepackage README migrated from common * open scene portal item README migrated from common * OpenStreetMap Layer README migrated from common * PerformWSpatialOperations java README migrated from common * PerformWSpatialOperations kotlin README migrated from common * PictureMarkerSymbols README migrated from common * play a kml tour README migrated from common * play a kml tour README migrated from common * slight rewrite. * address review comments * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * replace set with pass Co-Authored-By: sorenoid <sorenoid@gmail.com> * use java setter Co-Authored-By: sorenoid <sorenoid@gmail.com> * use setRasterRenderer Co-Authored-By: sorenoid <sorenoid@gmail.com> * instantiate an ArcGISMap improvement Co-Authored-By: sorenoid <sorenoid@gmail.com> * Readmes/densify to display drawing status (#729) * densify and dictionary * display annotation * location display * draw status * add period * start to startAsync * update symbolizeshapefile readme * update read symbols mobile readme * update take screenshot readme * update terrain exaggeration readme * update arcgistiledlayer readme * update time based query readme * update token authentication readme * update feature layer update attributes readme * revert back to useful how to use description * update feature layer update geometries readme * update update related features readme * revert image description * address review comments * removed extraneous API. provided a code example for How it works. * change name. Make download instructions more explicit. * make "How to use" more android UI specific. Use getter and setter terminology in How it works, rather than classnames. Other minor tweaks. * specify that controls are accessible through action bar button * turn quasi variable name into plain English. * fix run-on code style. change variable name * mention overflow menu * remove non android API * code example * Readmes/attributionviewchange to buffer (#712) * attributionviewchange * authenticate * blendrenderer * wfslayers * buffer * click to tap * change select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * make Tags less bold Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change method call to match java Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add full stop Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change layoutparams step description * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * change Map View to MapView Co-Authored-By: sorenoid <sorenoid@gmail.com> * remaining pr fixes Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> * Readmes/display grid to display map (#730) * displayGrid * displayKML * displayKMLNetwork * displayLayerViewState * displayMap * API name changes * kml readme fixes * layer view state changes * display map changes * remove nonexistant API * Readmes/create and save map to delete features (#724) * createAndSaveMap * createTerrainFromLocalRaster * createTerrainFromTilePackage * cutGeometry * deleteFeatures * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove backticks * fix ArcGISMap name * remove word * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove brackets on kotlin method calls * remove oauth note Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Readmes/display scene to distance measurement (#731) * displayScene * displaySceneInAR, displayWFS, distance composite symbol * distanceMeasurement * arView to mArView * fix API method names Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api method * FIX TYPOS Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix measurement changed callback references Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * improve grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * improve table and server update description * update vector tile basemaps readme * update beneath terrain readme * update view point cloud readme * update viewshed camera * update viewshed geoelement readme * minor improvements * refactor as optional comment * address review comments * update viewshedgeoprocessing readme * update viewshed location readme * update web tiled layer * update wfsxmlquery readme * update wms layer url * update wmts layer readme * change drop down to navigation Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * make imperative Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Readmes/choose camera controller to control annotation sublayer visibility (#717) * chooseCameraController * clipGeometry * colorMapRenderer * configureSubnetworkTrace * controlAnnotationSublayerVisibility * fix colormap-renderer grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix class reference name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix Domain reference Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove code tag from barriers Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change traceconfiguration name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove extra space Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * utility prefix * step 8 clarification * redo previous pr fixes Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * address review comments * make spatial operations example "How it works" more explicit. remove newline and redundant information, other minor changes. * more files for last commit * add period to end of new sentence. * Readmes/downloadprelanned to explore scenesin flyover (#732) * downloadPreplanned * editSyncFeatures * editFeatureAttachments * elevationAtPoint * exploreSceneInFlyoverAR * java to android links * edit and sync features changes * api method calls * clarify .start method Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove line of asterisks * remove unused instruction * remove article in title Co-authored-by: sorenoid <sorenoid@gmail.com> * improve readability Co-Authored-By: sorenoid <sorenoid@gmail.com> * shorten description * address review comments * Export tiles to feature layer dictionary renderer (#737) * exportTiles * featureCollectionLayer * FeatureCollectionLayerQuery * featureLayerDefinitionExpression * featureLayerDictionaryRenderer * fix typo Co-Authored-By: sorenoid <sorenoid@gmail.com> * add method call to api Co-Authored-By: sorenoid <sorenoid@gmail.com> * address PR changes * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add new keyword Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * lowercase instance name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * simplify instruction Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api from how to use * reword geometry type instruction * definition expression changes * and to or Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix portal user API usage and make grammar imperative. remove redundant step from play a kml tour. * fix up spatial operations "How to use the sample" to be more sprecific to the android implementations" * remove instruction that isn't sensible in the android app * fix up PortalUser kotlin version * two kotlin READMES i missed. * migrate java/create-geometries README from common * Readmes/feature layer extrusion to feature layer feature service (#738) * featureLayerExtrusion * featureLayerFeatureService * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove duplicates * pr changes * fix wording * fix extrusion api Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * changes to integrated windows auth kotlin README, also copied to the java version, and a small vraiable name change in set-min-max * update link to guide * remove mention of domain which we don't use in Java * Update java/openstreetmap-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/project/README.md * Update java/raster-function-service/README.md * Update java/raster-function-service/README.md * fixes (#771) * fixes * Update README.md * Missing readmes (#772) * integrated windows auth * integrated windows auth * set min max scale * unique value renderer * feautre layer show attributes * title casing * expand use case Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix method names Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix generate offline map how to use * Readme suggestions and comments (#776) * pr fixes * fixes * fixes * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Update java/animate-3d-graphic/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * Update java/buffer/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * remove returnDirections parameter instruction * Update java/viewshed-geoelement/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update java/add-enc-exchange-set/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/add-graphics-symbols/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/apply-scheduled-updates-to-preplanned-map-area/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/raster-function-service/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/token-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update README.md * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/export-tiles/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-query/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-show-attributes/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map-with-local-basemap/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/find-service-area-interactive/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/list-related-features/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/manage-operational-layers/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/offline-geocode/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/open-existing-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/read-geopackage/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/service-feature-table-cache/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/set-map-spatial-reference/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-callout/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-labels-on-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * rename barriers list Co-authored-by: hud10837 <60605708+hud10837@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com>
TADraeseke
added a commit
that referenced
this pull request
Apr 9, 2020
* Hud10837/display device location kotlin (#751) * initial file transfer * fix compiler errors * working sample * cleanup * move permissions check etc to separate function * add readme, screenshot, metadata and do checklist * add bg to spinner * move spinner above attribution bar * rename params for attributionviewlayoutchangelistener * close mapview tag Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * pr fixes * fix permissions request functionality * change v to view Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix mode typo Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * address pr fixes * fix readme numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove metadata whitespace * address pr comments * put periods back in Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Readme migration from common (#768) * identify kml features README for java android sample. * update read geopackage from review comments * remove unused class reference * identify kml features README with method names in relevant api for now. * IWA sample README update. * line of sight geoelement README update from common samples. offline data section removed because files are built into the app. * location line of sight README updated from common. * README updated for kotlin identify-layers from common * identify-layers java and kotlin, identify-kml-features, IWA, line of sight geoelement, and line of sight location READMES updated from common * add missing word to sentence. * remove method parentheses * List KML Contents sample README from common * List related features sample README from common * list transformations by suitability sample README from common * manage bookmarks README updated from common samples * manage operational layers README updated from common samples * whitespace * map image layer README migrated from common * change sublayer visibility README migrated from common * map image layer tables README migrated from common * Map Initial Area README migrated from common * map load status README migrated from common * whitespace * remove API from tags * remove API from tags * remove excess space * update how to use and how it works * remove comma * code review comments addressed * service feature table manual readme update * update about the data for current data used, and website links for android * update servicefeaturetable (cache) data and weblink * update set initial map location readme * update callout readme * click -> tap. Complete an incomplete sentence, and make usage more explicit. * click -> tap. Complete an incomplete sentence, and make usage more explicit. * update show labels on layer readme * update kotlin readme for data currently used * misused API methods fixed. Line of sight location usage reworded slightly. * kotlin update of identify-layers README.md * use consistent text and verbiage between the two line of sight samples * dont change name! * minor grammar fix * tweak transformation by suitability How it works section. * minor typo * tweak "How to use" section for indentify-layers * change IWA API classname * capitalization * sync java README to kotlin for identify-layers * README for map-reference-scale migrated from common. * README for map-rotation migrated from common. * README for set-map-spatial-reference migrated from common. * README for set-min-max-scale migrated from common. * README for mobile-map-search-and-route migrated from common. * README for navigate in AR migrated from common. part 1 * Revert "README updated for kotlin identify-layers from common" This reverts commit e35db38. * Update README.md * Revert "location line of sight README updated from common." This reverts commit 5e3afa2. * Revert "line of sight geoelement README update from common samples. offline data section removed because files are built into the app." This reverts commit b7f4c7f. * Revert "IWA sample README update." This reverts commit e736708. * Revert "identify kml features README with method names in relevant api for now." This reverts commit 96b58b5. * Revert "identify kml features README for java android sample." This reverts commit 185b480. * americanize centered * Readmes/change atmosphere to change viewpoint (#716) * change-atmosphere-effect * change-basemaps * changefeaturelayerrenderer * changesublayerrenderer * changeViewpoint * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove method call Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * update show magnifier readme * update simple marker symbol * update simple renderer readme * update sketch editor readme * update spatial relations readme * update statistical query readme * Update README.md * update stretch renderer readme * update style wms layer readme * update surface placement readme * self review improvements * change the name. * address review comments * specify java API from generic common API verbiage * specify java API from .net-like common API verbiage * rephrase a few sentences * sync java to kotlin identify-layers README * reference offline data section explicitly. * add offline data section. * fix up how it works section. * remove extraneous API listing. standardiza "How it works" pseudocode. * javafy the API usage in How it works * clean up a few sentences and API classes * fix up a few sentences * navogateroute README migrated from common. * offlinegeocode README migrated from common * openexistingmap aka OpenMapUrl README migrated from common * openmobilemappackage README migrated from common * openmobilescenepackage README migrated from common * open scene portal item README migrated from common * OpenStreetMap Layer README migrated from common * PerformWSpatialOperations java README migrated from common * PerformWSpatialOperations kotlin README migrated from common * PictureMarkerSymbols README migrated from common * play a kml tour README migrated from common * play a kml tour README migrated from common * slight rewrite. * address review comments * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * replace set with pass Co-Authored-By: sorenoid <sorenoid@gmail.com> * use java setter Co-Authored-By: sorenoid <sorenoid@gmail.com> * use setRasterRenderer Co-Authored-By: sorenoid <sorenoid@gmail.com> * instantiate an ArcGISMap improvement Co-Authored-By: sorenoid <sorenoid@gmail.com> * Readmes/densify to display drawing status (#729) * densify and dictionary * display annotation * location display * draw status * add period * start to startAsync * update symbolizeshapefile readme * update read symbols mobile readme * update take screenshot readme * update terrain exaggeration readme * update arcgistiledlayer readme * update time based query readme * update token authentication readme * update feature layer update attributes readme * revert back to useful how to use description * update feature layer update geometries readme * update update related features readme * revert image description * address review comments * removed extraneous API. provided a code example for How it works. * change name. Make download instructions more explicit. * make "How to use" more android UI specific. Use getter and setter terminology in How it works, rather than classnames. Other minor tweaks. * specify that controls are accessible through action bar button * turn quasi variable name into plain English. * fix run-on code style. change variable name * mention overflow menu * remove non android API * code example * Readmes/attributionviewchange to buffer (#712) * attributionviewchange * authenticate * blendrenderer * wfslayers * buffer * click to tap * change select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * make Tags less bold Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change method call to match java Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add full stop Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change layoutparams step description * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * change Map View to MapView Co-Authored-By: sorenoid <sorenoid@gmail.com> * remaining pr fixes Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> * Readmes/display grid to display map (#730) * displayGrid * displayKML * displayKMLNetwork * displayLayerViewState * displayMap * API name changes * kml readme fixes * layer view state changes * display map changes * remove nonexistant API * Readmes/create and save map to delete features (#724) * createAndSaveMap * createTerrainFromLocalRaster * createTerrainFromTilePackage * cutGeometry * deleteFeatures * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove backticks * fix ArcGISMap name * remove word * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove brackets on kotlin method calls * remove oauth note Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Readmes/display scene to distance measurement (#731) * displayScene * displaySceneInAR, displayWFS, distance composite symbol * distanceMeasurement * arView to mArView * fix API method names Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api method * FIX TYPOS Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix measurement changed callback references Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * improve grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * improve table and server update description * update vector tile basemaps readme * update beneath terrain readme * update view point cloud readme * update viewshed camera * update viewshed geoelement readme * minor improvements * refactor as optional comment * address review comments * update viewshedgeoprocessing readme * update viewshed location readme * update web tiled layer * update wfsxmlquery readme * update wms layer url * update wmts layer readme * change drop down to navigation Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * make imperative Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Readmes/choose camera controller to control annotation sublayer visibility (#717) * chooseCameraController * clipGeometry * colorMapRenderer * configureSubnetworkTrace * controlAnnotationSublayerVisibility * fix colormap-renderer grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix class reference name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix Domain reference Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove code tag from barriers Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change traceconfiguration name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove extra space Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * utility prefix * step 8 clarification * redo previous pr fixes Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * address review comments * make spatial operations example "How it works" more explicit. remove newline and redundant information, other minor changes. * more files for last commit * add period to end of new sentence. * Readmes/downloadprelanned to explore scenesin flyover (#732) * downloadPreplanned * editSyncFeatures * editFeatureAttachments * elevationAtPoint * exploreSceneInFlyoverAR * java to android links * edit and sync features changes * api method calls * clarify .start method Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove line of asterisks * remove unused instruction * remove article in title Co-authored-by: sorenoid <sorenoid@gmail.com> * improve readability Co-Authored-By: sorenoid <sorenoid@gmail.com> * shorten description * address review comments * Export tiles to feature layer dictionary renderer (#737) * exportTiles * featureCollectionLayer * FeatureCollectionLayerQuery * featureLayerDefinitionExpression * featureLayerDictionaryRenderer * fix typo Co-Authored-By: sorenoid <sorenoid@gmail.com> * add method call to api Co-Authored-By: sorenoid <sorenoid@gmail.com> * address PR changes * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add new keyword Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * lowercase instance name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * simplify instruction Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api from how to use * reword geometry type instruction * definition expression changes * and to or Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix portal user API usage and make grammar imperative. remove redundant step from play a kml tour. * fix up spatial operations "How to use the sample" to be more sprecific to the android implementations" * remove instruction that isn't sensible in the android app * fix up PortalUser kotlin version * two kotlin READMES i missed. * migrate java/create-geometries README from common * Readmes/feature layer extrusion to feature layer feature service (#738) * featureLayerExtrusion * featureLayerFeatureService * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove duplicates * pr changes * fix wording * fix extrusion api Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * changes to integrated windows auth kotlin README, also copied to the java version, and a small vraiable name change in set-min-max * update link to guide * remove mention of domain which we don't use in Java * Update java/openstreetmap-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/project/README.md * Update java/raster-function-service/README.md * Update java/raster-function-service/README.md * fixes (#771) * fixes * Update README.md * Missing readmes (#772) * integrated windows auth * integrated windows auth * set min max scale * unique value renderer * feautre layer show attributes * title casing * expand use case Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix method names Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix generate offline map how to use * Readme suggestions and comments (#776) * pr fixes * fixes * fixes * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Update java/animate-3d-graphic/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * Update java/buffer/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * remove returnDirections parameter instruction * Update java/viewshed-geoelement/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update java/add-enc-exchange-set/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/add-graphics-symbols/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/apply-scheduled-updates-to-preplanned-map-area/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/raster-function-service/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/token-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update README.md * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/export-tiles/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-query/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-show-attributes/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map-with-local-basemap/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/find-service-area-interactive/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/list-related-features/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/manage-operational-layers/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/offline-geocode/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/open-existing-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/read-geopackage/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/service-feature-table-cache/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/set-map-spatial-reference/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-callout/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-labels-on-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * working sample * rename, add readme, screenshot, metadata and comments * fix versions * PR fixes * reformat * Update kotlin/display-utility-associations/src/main/java/com/esri/arcgisruntime/sample/displayutilityassociations/MainActivity.kt Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> Co-authored-by: hud10837 <60605708+hud10837@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com>
TADraeseke
added a commit
that referenced
this pull request
Apr 15, 2020
* Hud10837/display device location kotlin (#751) * initial file transfer * fix compiler errors * working sample * cleanup * move permissions check etc to separate function * add readme, screenshot, metadata and do checklist * add bg to spinner * move spinner above attribution bar * rename params for attributionviewlayoutchangelistener * close mapview tag Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * pr fixes * fix permissions request functionality * change v to view Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix mode typo Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * address pr fixes * fix readme numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove metadata whitespace * address pr comments * put periods back in Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Readme migration from common (#768) * identify kml features README for java android sample. * update read geopackage from review comments * remove unused class reference * identify kml features README with method names in relevant api for now. * IWA sample README update. * line of sight geoelement README update from common samples. offline data section removed because files are built into the app. * location line of sight README updated from common. * README updated for kotlin identify-layers from common * identify-layers java and kotlin, identify-kml-features, IWA, line of sight geoelement, and line of sight location READMES updated from common * add missing word to sentence. * remove method parentheses * List KML Contents sample README from common * List related features sample README from common * list transformations by suitability sample README from common * manage bookmarks README updated from common samples * manage operational layers README updated from common samples * whitespace * map image layer README migrated from common * change sublayer visibility README migrated from common * map image layer tables README migrated from common * Map Initial Area README migrated from common * map load status README migrated from common * whitespace * remove API from tags * remove API from tags * remove excess space * update how to use and how it works * remove comma * code review comments addressed * service feature table manual readme update * update about the data for current data used, and website links for android * update servicefeaturetable (cache) data and weblink * update set initial map location readme * update callout readme * click -> tap. Complete an incomplete sentence, and make usage more explicit. * click -> tap. Complete an incomplete sentence, and make usage more explicit. * update show labels on layer readme * update kotlin readme for data currently used * misused API methods fixed. Line of sight location usage reworded slightly. * kotlin update of identify-layers README.md * use consistent text and verbiage between the two line of sight samples * dont change name! * minor grammar fix * tweak transformation by suitability How it works section. * minor typo * tweak "How to use" section for indentify-layers * change IWA API classname * capitalization * sync java README to kotlin for identify-layers * README for map-reference-scale migrated from common. * README for map-rotation migrated from common. * README for set-map-spatial-reference migrated from common. * README for set-min-max-scale migrated from common. * README for mobile-map-search-and-route migrated from common. * README for navigate in AR migrated from common. part 1 * Revert "README updated for kotlin identify-layers from common" This reverts commit e35db38. * Update README.md * Revert "location line of sight README updated from common." This reverts commit 5e3afa2. * Revert "line of sight geoelement README update from common samples. offline data section removed because files are built into the app." This reverts commit b7f4c7f. * Revert "IWA sample README update." This reverts commit e736708. * Revert "identify kml features README with method names in relevant api for now." This reverts commit 96b58b5. * Revert "identify kml features README for java android sample." This reverts commit 185b480. * americanize centered * Readmes/change atmosphere to change viewpoint (#716) * change-atmosphere-effect * change-basemaps * changefeaturelayerrenderer * changesublayerrenderer * changeViewpoint * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix change-basemap grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove method call Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * dash to asterisk Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * update show magnifier readme * update simple marker symbol * update simple renderer readme * update sketch editor readme * update spatial relations readme * update statistical query readme * Update README.md * update stretch renderer readme * update style wms layer readme * update surface placement readme * self review improvements * change the name. * address review comments * specify java API from generic common API verbiage * specify java API from .net-like common API verbiage * rephrase a few sentences * sync java to kotlin identify-layers README * reference offline data section explicitly. * add offline data section. * fix up how it works section. * remove extraneous API listing. standardiza "How it works" pseudocode. * javafy the API usage in How it works * clean up a few sentences and API classes * fix up a few sentences * navogateroute README migrated from common. * offlinegeocode README migrated from common * openexistingmap aka OpenMapUrl README migrated from common * openmobilemappackage README migrated from common * openmobilescenepackage README migrated from common * open scene portal item README migrated from common * OpenStreetMap Layer README migrated from common * PerformWSpatialOperations java README migrated from common * PerformWSpatialOperations kotlin README migrated from common * PictureMarkerSymbols README migrated from common * play a kml tour README migrated from common * play a kml tour README migrated from common * slight rewrite. * address review comments * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * Update java/show-magnifier/README.md Co-Authored-By: sorenoid <sorenoid@gmail.com> * replace set with pass Co-Authored-By: sorenoid <sorenoid@gmail.com> * use java setter Co-Authored-By: sorenoid <sorenoid@gmail.com> * use setRasterRenderer Co-Authored-By: sorenoid <sorenoid@gmail.com> * instantiate an ArcGISMap improvement Co-Authored-By: sorenoid <sorenoid@gmail.com> * Readmes/densify to display drawing status (#729) * densify and dictionary * display annotation * location display * draw status * add period * start to startAsync * update symbolizeshapefile readme * update read symbols mobile readme * update take screenshot readme * update terrain exaggeration readme * update arcgistiledlayer readme * update time based query readme * update token authentication readme * update feature layer update attributes readme * revert back to useful how to use description * update feature layer update geometries readme * update update related features readme * revert image description * address review comments * removed extraneous API. provided a code example for How it works. * change name. Make download instructions more explicit. * make "How to use" more android UI specific. Use getter and setter terminology in How it works, rather than classnames. Other minor tweaks. * specify that controls are accessible through action bar button * turn quasi variable name into plain English. * fix run-on code style. change variable name * mention overflow menu * remove non android API * code example * Readmes/attributionviewchange to buffer (#712) * attributionviewchange * authenticate * blendrenderer * wfslayers * buffer * click to tap * change select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * make Tags less bold Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change method call to match java Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add full stop Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * select to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix typo in height Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change layoutparams step description * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * lowercase method names Co-Authored-By: sorenoid <sorenoid@gmail.com> * change Map View to MapView Co-Authored-By: sorenoid <sorenoid@gmail.com> * remaining pr fixes Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> * Readmes/display grid to display map (#730) * displayGrid * displayKML * displayKMLNetwork * displayLayerViewState * displayMap * API name changes * kml readme fixes * layer view state changes * display map changes * remove nonexistant API * Readmes/create and save map to delete features (#724) * createAndSaveMap * createTerrainFromLocalRaster * createTerrainFromTilePackage * cutGeometry * deleteFeatures * fix typo Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove backticks * fix ArcGISMap name * remove word * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove brackets on kotlin method calls * remove oauth note Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Readmes/display scene to distance measurement (#731) * displayScene * displaySceneInAR, displayWFS, distance composite symbol * distanceMeasurement * arView to mArView * fix API method names Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api method * FIX TYPOS Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix measurement changed callback references Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * improve grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * improve table and server update description * update vector tile basemaps readme * update beneath terrain readme * update view point cloud readme * update viewshed camera * update viewshed geoelement readme * minor improvements * refactor as optional comment * address review comments * update viewshedgeoprocessing readme * update viewshed location readme * update web tiled layer * update wfsxmlquery readme * update wms layer url * update wmts layer readme * change drop down to navigation Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * make imperative Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Readmes/choose camera controller to control annotation sublayer visibility (#717) * chooseCameraController * clipGeometry * colorMapRenderer * configureSubnetworkTrace * controlAnnotationSublayerVisibility * fix colormap-renderer grammar Co-Authored-By: sorenoid <sorenoid@gmail.com> * fix class reference name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix Domain reference Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove code tag from barriers Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * change traceconfiguration name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove extra space Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * utility prefix * step 8 clarification * redo previous pr fixes Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * address review comments * make spatial operations example "How it works" more explicit. remove newline and redundant information, other minor changes. * more files for last commit * add period to end of new sentence. * Readmes/downloadprelanned to explore scenesin flyover (#732) * downloadPreplanned * editSyncFeatures * editFeatureAttachments * elevationAtPoint * exploreSceneInFlyoverAR * java to android links * edit and sync features changes * api method calls * clarify .start method Co-Authored-By: sorenoid <sorenoid@gmail.com> * remove line of asterisks * remove unused instruction * remove article in title Co-authored-by: sorenoid <sorenoid@gmail.com> * improve readability Co-Authored-By: sorenoid <sorenoid@gmail.com> * shorten description * address review comments * Export tiles to feature layer dictionary renderer (#737) * exportTiles * featureCollectionLayer * FeatureCollectionLayerQuery * featureLayerDefinitionExpression * featureLayerDictionaryRenderer * fix typo Co-Authored-By: sorenoid <sorenoid@gmail.com> * add method call to api Co-Authored-By: sorenoid <sorenoid@gmail.com> * address PR changes * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * add new keyword Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * click to tap Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * lowercase instance name Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * simplify instruction Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove api from how to use * reword geometry type instruction * definition expression changes * and to or Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix portal user API usage and make grammar imperative. remove redundant step from play a kml tour. * fix up spatial operations "How to use the sample" to be more sprecific to the android implementations" * remove instruction that isn't sensible in the android app * fix up PortalUser kotlin version * two kotlin READMES i missed. * migrate java/create-geometries README from common * Readmes/feature layer extrusion to feature layer feature service (#738) * featureLayerExtrusion * featureLayerFeatureService * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * fix wording Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * remove duplicates * pr changes * fix wording * fix extrusion api Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * changes to integrated windows auth kotlin README, also copied to the java version, and a small vraiable name change in set-min-max * update link to guide * remove mention of domain which we don't use in Java * Update java/openstreetmap-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/project/README.md * Update java/raster-function-service/README.md * Update java/raster-function-service/README.md * fixes (#771) * fixes * Update README.md * Missing readmes (#772) * integrated windows auth * integrated windows auth * set min max scale * unique value renderer * feautre layer show attributes * title casing * expand use case Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix method names Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * add parentheses Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * easy suggestions Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix generate offline map how to use * Readme suggestions and comments (#776) * pr fixes * fixes * fixes * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * remove static Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> * fix numbering Co-Authored-By: TADraeseke <TADraeseke@users.noreply.github.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * Update java/animate-3d-graphic/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * Update java/buffer/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update README.md * remove returnDirections parameter instruction * Update java/viewshed-geoelement/README.md Co-Authored-By: hud10837 <60605708+hud10837@users.noreply.github.com> * Update java/add-enc-exchange-set/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/add-graphics-symbols/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/apply-scheduled-updates-to-preplanned-map-area/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/raster-function-service/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update kotlin/token-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update README.md * Update kotlin/integrated-mesh-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/export-tiles/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-collection-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-query/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/feature-layer-show-attributes/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map-with-local-basemap/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/find-service-area-interactive/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/generate-offline-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/integrated-windows-authentication/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/list-related-features/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/manage-operational-layers/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/offline-geocode/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/open-existing-map/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/read-geopackage/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/service-feature-table-cache/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/set-map-spatial-reference/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-callout/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> * Update java/show-labels-on-layer/README.md Co-Authored-By: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com> Co-authored-by: TADraeseke <TADraeseke@users.noreply.github.com> * fixes for enc, tabletop ar, trace * version.gradle * remaining fixes * rename spatial operations * raster function service fixes * fixes * rename screenshot * move button activation out of navigation listener * revert java attribution view change * fix attribution view change * fix settings.gradle ordering Co-authored-by: hud10837 <60605708+hud10837@users.noreply.github.com> Co-authored-by: Soren Roth <sroth@esri.com> Co-authored-by: Rachael Ellen <rellen@esri.com> Co-authored-by: Rachael Ellen <36415565+Rachael-E@users.noreply.github.com> Co-authored-by: sorenoid <sorenoid@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @TADraeseke can you do a first review? This one is not as big as it looks, but there are two files---the java version had 3 separated into two separate packages, but I thought that was a bit confusing, so I moved the ItemData class (which is just a data class) inside the spinner file. Hopefully I didn't miss anything with all the package renaming.
Thanks!