Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: calcite-shell-center-row, if no actionBar specified get an error #1031

Closed
kevindoshier opened this issue Jul 10, 2020 · 1 comment
Closed

Bug: calcite-shell-center-row, if no actionBar specified get an error #1031

kevindoshier opened this issue Jul 10, 2020 · 1 comment
Assignees
@kevindoshier
Labels
3 - installed bug Something isn't working
Milestone
Ocean Princess

Comments

@kevindoshier
Copy link

kevindoshier commented Jul 10, 2020 •
edited
Loading

Summary

calcite-shell-center-row was updated to allow an actionBar to be added, awesome, but if I dont use an action bar this line throws an error

https://github.com/Esri/calcite-app-components/blob/master/src/components/calcite-shell-center-row/calcite-shell-center-row.tsx#L72

seen with 6.1.0

Actual Behavior

Expected Behavior

Allow calcite-center-row without an actionBar

Reproduction Steps

Relevant Info

@kevindoshier kevindoshier added 0 - new bug Something isn't working labels Jul 10, 2020
@kevindoshier kevindoshier changed the title Bug: calcite-center-row, if no actionBar specified get an error Bug: calcite-shell-center-row, if no actionBar specified get an error Jul 10, 2020
@driskull driskull self-assigned this Jul 10, 2020
@driskull driskull added this to the Ocean Princess milestone Jul 10, 2020
driskull added a commit that referenced this issue Jul 10, 2020
@driskull
#1031 fix shell center row error
f9fb8bf
@driskull driskull mentioned this issue Jul 10, 2020
Merged
asangma added a commit that referenced this issue Jul 10, 2020
@asangma
Added check for ActionBar for node reversal (#1031).
4bb97f0
driskull added a commit that referenced this issue Jul 10, 2020
@driskull
fix(shell-center-row): Error when no action-bar is provided (#1032)
050c136 
* #1031 fix shell center row error

* typing

* add test?

* cleanup

* cleanup

* rework tests
@driskull driskull assigned kevindoshier and unassigned driskull Jul 10, 2020
@kevindoshier
Copy link
Author

Thanks, looks good 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kevindoshier kevindoshier

Labels
3 - installed bug Something isn't working
Projects
None yet
Milestone
Ocean Princess
Development

No branches or pull requests
2 participants
@driskull @kevindoshier