Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Bug: User should not be able to use arrow keys on tip manager navigation buttons #307

Closed
annelfitz opened this issue Sep 27, 2019 · 2 comments
Assignees
Labels
3 - installed a11y bug Something isn't working
Milestone

Comments

@annelfitz
Copy link

Summary

For the navigation buttons in the tip manager, the user should only be able to interact with these buttons using the space bar or the enter key. These should not respond to the arrow keys.

Actual Behavior

When focused on the right arrow nav button, if you hit the left arrow key, it will go back. The function of this button should only be to view tips on the right, so we should avoid using arrow keys to interact with these navigation buttons.

Expected Behavior

Only the space bar and enter key can interact with these buttons.

Reproduction Steps

  1. https://esri.github.io/calcite-app-components/demos/calcite-tip-manager.html
  2. Focus on either the left or right arrow buttons of the tip manager, try using the arrow keys to move through the tips. You should only be able to use the space and enter

Relevant Info

@annelfitz annelfitz added bug Something isn't working 1 - assigned a11y labels Sep 27, 2019
@driskull driskull added this to the Choose Goose milestone Oct 1, 2019
@driskull
Copy link
Member

driskull commented Oct 1, 2019

I can take this one

@driskull driskull assigned driskull and unassigned pr3tori4n Oct 1, 2019
driskull added a commit that referenced this issue Oct 1, 2019
#306 allow scrolling via arrows inside content
driskull added a commit that referenced this issue Oct 1, 2019
#307 key navigation only works on specified target
@driskull driskull assigned driskull and annelfitz and unassigned driskull Oct 1, 2019
@annelfitz
Copy link
Author

annelfitz commented Oct 3, 2019

Looks good! (I don't have any privileges to change the label or close this issue but consider it verified and closed) 💥

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
3 - installed a11y bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants