This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
feat(flow-item,panel): Add intl string properties. #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driskull
added
enhancement
|
@jcfranco merging. Let me know if follow up issues arise. |
jcfranco
reviewed
Mar 12, 2020
| @@ -70,17 +70,35 @@ export class CalciteFlowItem { | |||
| /** | |||
| * 'Back' text string. | |||
| */ | |||
| @Prop() textBack = TEXT.back; | |||
| @Prop() intlBack?: string; | |||
There was a problem hiding this comment.
Nitpick: can these be placed in alphabetical order?
|
Yeah, lets note that they should have a value. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #818
Summary
Enhancement: Rename text props we provide a default for to have
intl-prefix #818