Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: Rename text props we provide a default for to have intl- prefix #818

Closed
18 tasks done
driskull opened this issue Feb 11, 2020 · 7 comments
Closed
18 tasks done

Enhancement: Rename text props we provide a default for to have intl- prefix #818

driskull opened this issue Feb 11, 2020 · 7 comments
Assignees
@kat10140
Labels
4 - verified architecture doc Anything related to documentation enhancement New feature request for an existing component intl p - medium
Milestone
James Baxter

Comments

@driskull
Copy link
Member

driskull commented Feb 11, 2020 •
edited
Loading

Description

Enhancement: Rename text props we provide a default for to have intl- prefix

Acceptance Criteria

All properties that we provide default text in English be prefixed with intl- so that we can document the purpose of these properties and have them named consistently.

Relevant Info

Also consider having a bundle file where we can reuse some of the common English strings for the defaults.

Which Component

All

Example Use Case

  • text-close => intl-close
  • text-back => intl-back

Props to change

calcite-action-bar

  • textExpand => intlExpand
  • textCollapse => intlCollapse

calcite-action-pad

  • textExpand => intlExpand
  • textCollapse => intlCollapse

calcite-block

  • textExpand => intlExpand
  • textCollapse => intlCollapse

calcite-block-section

  • textExpand => intlExpand
  • textCollapse => intlCollapse

calcite-filter

  • textLabel => label
  • textPlaceholder => placeholder

calcite-flow-item

  • textBack => intlBack
  • textClose => intlClose
  • textOpen => intlOpen

calcite-panel

  • textClose => intlClose

calcite-tip

  • textClose => intlClose

calcite-tip-manager

  • textClose => intlClose
  • textNext => intlNext
  • textPrevious => intlPrevious
@driskull driskull added enhancement New feature request for an existing component 1 - assigned p - medium architecture doc Anything related to documentation breaking This introduces a breaking change. labels Feb 11, 2020
@driskull driskull added this to the Ice King milestone Feb 11, 2020
@driskull driskull self-assigned this Feb 11, 2020
@driskull
Copy link
Member Author

@jcfranco @asangma do we want to do this as a breaking change or as deprecations?

@jcfranco
Copy link
Member

I vote to deprecate and remove later.

@driskull
Copy link
Member Author

driskull commented Feb 13, 2020 •
edited
Loading

moved to top

driskull added a commit that referenced this issue Feb 14, 2020
@driskull
#818 deprecate text for locale (action-bar & action-pad)
6e8f77c
@driskull driskull mentioned this issue Feb 14, 2020
Merged
@driskull driskull changed the title Enhancement: Rename text props we provide a default for to have locale- prefix Enhancement: Rename text props we provide a default for to have intl- prefix Feb 19, 2020
@driskull driskull removed the breaking This introduces a breaking change. label Feb 20, 2020
This was referenced Feb 21, 2020
Merged
Merged
@driskull
Copy link
Member Author

@jcfranco do you think you could take the block and filter?

@driskull driskull added the intl label Feb 21, 2020
@jcfranco
Copy link
Member

@driskull Sure thing.

@jcfranco jcfranco self-assigned this Feb 25, 2020
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
Issue #818: Add intl props to block, block-section and filter.
146dd56
@jcfranco jcfranco mentioned this issue Feb 27, 2020
Merged
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
Issue #818: Add missing intl prop.
e324b5c
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
Issue #818: Add missing intl prop.
3a1a123
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
Issue #818: Tidy up.
1a18ce1
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
Issue #818: Update stories.
a3eea71
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
feat(block, block-section, filter): add intl props (#852)
8384fca 
#818
@jcfranco jcfranco mentioned this issue Feb 27, 2020
Merged
jcfranco added a commit that referenced this issue Feb 27, 2020
@jcfranco
refactor(block, block-section, filter): make props optional and add t…
c0d3a7e 
…ext fallbacks (#853)

#818
@kat10140 kat10140 modified the milestones: Ice King, James Baxter Mar 10, 2020
driskull added a commit that referenced this issue Mar 12, 2020
@driskull
feat(action-pad,action-bar): Add intl string properties. (#823)
a261c0a 
* #818 deprecate text for locale (action-bar & action-pad)

* stories

* rename locale to intl

* readmes

* use intl in stories

* cleanup

* put TEXT back in resources
@kat10140
Copy link
Contributor

looks good. any reason we don't have intlPlaceholder for filter? closing

@driskull
Copy link
Member Author

any reason we don't have intlPlaceholder for filter? closing

Because we don't supply a default value for it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified architecture doc Anything related to documentation enhancement New feature request for an existing component intl p - medium
Projects
None yet
Milestone
James Baxter
Development

No branches or pull requests
3 participants
@jcfranco @driskull @kat10140