Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: calcite-shell - add slot for resizeable area in the middle bottom #935

Closed
kevindoshier opened this issue Apr 21, 2020 · 9 comments
Assignees
Milestone

Comments

@kevindoshier
Copy link

kevindoshier commented Apr 21, 2020

Description

For the new table addition to the mapviewer we would like an slot added to the calcite-shell component that positions itself at the middle bottom, and is resizeable, you can see a design for this is in slide 4 of this powerpoint here

image

There should be a place for a title, a 3-dots menu icon, and an expand icon but in a way so that it won't use up too much space vertically. The user should be able to drag the top edge of the panel to make the panel higher. The expand action would give the panel a height of 100%, so that it completely covers the map. The app could have open vertical shell panels on either side, which the user can close and open while the bottom panel is visible.

In a future release of the table there could be up to 4 bottom panels aligned vertically (each with its own header), like this:

cc @AdelheidF

Acceptance Criteria

Relevant Info

Which Component

Example Use Case

@kevindoshier kevindoshier added 0 - new enhancement New feature request for an existing component labels Apr 21, 2020
@driskull
Copy link
Member

@asangma @kevindoshier some questions:

  • Is it always resizable or would that need to be an option?
  • The ... is built into the FeatureTable right? Same with the title?
  • What would be the name of this slot? shell-bottom?

Sounds like we just need a slot that is resizable when populated.

@kevindoshier
Copy link
Author

kevindoshier commented Apr 21, 2020

@driskull - yeah that would be nice I think if its configurable to be resizeable or not, maybe also have preset sizes? Not sure on that but like a s, m l? Sort of like how the modal has different sizes all the way up to full screen.

For the title, I missed that part, we would want the title, and action slot just like the flow has, so we could add actions to the "..." menu, and a title.

shell-bottom works for me

@driskull
Copy link
Member

@asangma can you help create a design for this? I'm not sure what parts are the FeatureTable and what needs to be a bottom-panel.

@ekim2
Copy link

ekim2 commented Apr 22, 2020

After talking with the Charts team, they also want to use this slot for charts. Possibilities include:

  • more than one chart displayed (Could it be a matrix, say 2x2 of charts?)
  • a chart and a table
  • Would we be able to have more than one of these slots? Say a table in one slot, then a set of charts displayed in a slot above.

@driskull
Copy link
Member

I think we'll allow a slot for putting stuff in the bottom of the shell and it will be up to the app to toggle what is currently shown there.

I'm not sure if we should build in the resizing or if we would add a shell-panel-bottom or something to handle the actions and resizing functionality.

@jcfranco @asangma we'll need to discuss in our next meeting or during a MapMaker meeting.

@driskull
Copy link
Member

We can deprecate the tip-manager slot and just go with a slot for putting things in the bottom.

We might just be able to build resizing into the calcite-panel and then that could be used to handle the resizing part as well as the title and actions.

@subgan82
Copy link

subgan82 commented Apr 24, 2020

Charts also will leverage this slot to show one or more charts

Screen Shot 2020-04-28 at 11 03 58 AM

@driskull
Copy link
Member

For now, we will add a slot to handle this. We will setup a discussion for how data tables should work in the new map viewer and come up with a design.

asangma added a commit that referenced this issue May 1, 2020
…cite-shell (#950)

* #935 add slot "bottom-panel" and deprecate "tip-manager" on shell

* working but still some issues

* Adjustments to keep bottom-panel from pusing contextual-panel off frame.

* Added calcite-shell-center-row component and associated styles. TODO: collapsed event.

* Added content node in order to recieve the `hidden` attribute for the `collapsed` property.

* Reverted the removal of the tip-manager slot. Arranged nodes in shell to put center-row after contextual-panel and added associated flex order.

* Added demo app for center-row.

* added e2e

* updated e2e

* Rearranged nodes. Nixed styles no longer needed after rearranging nodes.

* Added shell-center-row to shell Storybook.

* Removed collapsed property and associated tests. Added expand/collpase toggle to demo.

* Removed collapsed property from storybook.

* Removed unused Watch import.

* Fixed e2e test.

* restored tip-manager slot references

* Fixed e2e test. Reset block-configuration demo.

* removed non-behavioral test.

Co-authored-by: Matt Driscoll <MDriscoll@esri.com>
@driskull driskull assigned kevindoshier and unassigned driskull and asangma May 4, 2020
@driskull driskull added 3 - installed and removed 0 - new enhancement New feature request for an existing component labels May 4, 2020
@driskull driskull added this to the Lumpy Space Princess milestone May 4, 2020
@jcfranco
Copy link
Member

jcfranco commented Oct 7, 2020

Issue moved to Esri/calcite-components #1077 via ZenHub

@jcfranco jcfranco closed this as completed Oct 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants