This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
feat: new calcite-shell-center-row component and updated slot for calcite-shell #950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Generally looking pretty good tho. |
asangma
changed the title
driskull
suggested changes
Apr 30, 2020
… collapsed event.
… `collapsed` property.
… to put center-row after contextual-panel and added associated flex order.
asangma
changed the title
driskull
reviewed
May 1, 2020
src/components/calcite-shell-center-row/calcite-shell-center-row.tsx
Outdated
Show resolved
Hide resolved
|
Oh! I forgot to add a Storybook. |
driskull
suggested changes
May 1, 2020
src/components/calcite-shell-center-row/calcite-shell-center-row.e2e.ts
Outdated
Show resolved
Hide resolved
src/components/calcite-shell-center-row/calcite-shell-center-row.e2e.ts
Outdated
Show resolved
Hide resolved
src/components/calcite-shell-center-row/calcite-shell-center-row.e2e.ts
Outdated
Show resolved
Hide resolved
|
Thanks @driskull! |
|
I shall MURGLE unless you have any concerns, @jcfranco. :) |
|
Hurm...there might be a layout bug I overlooked. |
jcfranco
approved these changes
May 1, 2020
| expect(isVisible).toBe(true); | ||
| }); | ||
|
|
||
| it("should be accessible", async () => { |
There was a problem hiding this comment.
FIXME: Drop the curly braces to properly wire up the test. accessible returns a promise that needs to be passed as the test (similar to the other tests using the helpers).
it("should be accessible", async () =>
accessible("<calcite-shell-center-row><div>content</div></calcite-shell-center-row>")
);| } | ||
| ])); | ||
|
|
||
| it("should show row content", async () => { |
There was a problem hiding this comment.
What is this test for? It doesn't seem to be testing behavior.
There was a problem hiding this comment.
Heh...I was totes copying what shell-panel did. I can remove it.
|
Thanks @jcfranco ! I'll make updates. |
|
@jcfranco Updated! 🚀 |
|
Nice @asangma !!! 🥳 |
|
Thanks you rockers! 🤘🏽 |
|
MURGLES! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some things that might need rethinking here, but I am not sure.
One super minor thing is whether we should rename bottom-panel to center-panel and give it an alignment prop for top and bottom.
The major things are
detachedwith the bottom slot, right now, I'm just targeting that propertycc @kat10140 @jcfranco