Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: shell-center-row. Move bg-color and border styles from .content to :host #955

Closed
asangma opened this issue May 5, 2020 · 7 comments
Assignees
Labels
4 - verified enhancement New feature request for an existing component

Comments

@asangma
Copy link
Contributor

asangma commented May 5, 2020

Description

A couple styles are in this components shadow DOM.
I think it'd be good to move those styles to the host so that app devs can have little more control over ShellCenterRow in case they want to something like this:
image

I'm open to discussing whether this is a good pattern or not.

Acceptance Criteria

  • more readily available base styles

Which Component

CalciteShellCenterRow

Example Use Case

Charts.

@asangma asangma added enhancement New feature request for an existing component 1 - assigned labels May 5, 2020
@asangma asangma added this to the Lumpy Space Princess milestone May 5, 2020
@asangma asangma self-assigned this May 5, 2020
@asangma
Copy link
Contributor Author

asangma commented May 5, 2020

Mind you...I'm not stoked on that xp 👆🏽but I think it'd be good to be able to reset the bg-color and border if need be.

@driskull
Copy link
Member

driskull commented May 5, 2020

@asangma can't we just flexbox the slotted calcite-shell-center-row components so that they take up the space available?

@asangma
Copy link
Contributor Author

asangma commented May 5, 2020

We could. I think if someone wants add columns inside the row component, they can style a div to do that and put it into the default slot.

I am thinking though that maybe we set the bg-color to transparent as you suggested in a related conversation. We could also want to nix the border on center-row. Would need to nix the border from shell-panel to match.

@driskull
Copy link
Member

driskull commented May 5, 2020

I'm ok with that. As long as we're consistent

@asangma
Copy link
Contributor Author

asangma commented May 5, 2020

Cool.

@asangma
Copy link
Contributor Author

asangma commented May 8, 2020

Verfee please.

@kat10140
Copy link
Contributor

kat10140 commented May 8, 2020

ferf!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified enhancement New feature request for an existing component
Projects
None yet
Development

No branches or pull requests

3 participants