This repository has been archived by the owner on Jun 29, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Enhancement: shell-center-row. Move bg-color and border styles from .content to :host #955
Labels
Milestone
Comments
asangma
added
enhancement
New feature request for an existing component
1 - assigned
labels
May 5, 2020
Mind you...I'm not stoked on that xp 👆🏽but I think it'd be good to be able to reset the bg-color and border if need be. |
@asangma can't we just flexbox the slotted |
We could. I think if someone wants add columns inside the row component, they can style a div to do that and put it into the default slot. I am thinking though that maybe we set the bg-color to transparent as you suggested in a related conversation. We could also want to nix the border on center-row. Would need to nix the border from shell-panel to match. |
I'm ok with that. As long as we're consistent |
Cool. |
asangma
added a commit
that referenced
this issue
May 6, 2020
asangma
added a commit
that referenced
this issue
May 7, 2020
Verfee please. |
ferf!! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description
A couple styles are in this components shadow DOM.
I think it'd be good to move those styles to the
host
so that app devs can have little more control over ShellCenterRow in case they want to something like this:I'm open to discussing whether this is a good pattern or not.
Acceptance Criteria
Which Component
CalciteShellCenterRow
Example Use Case
Charts.
The text was updated successfully, but these errors were encountered: