Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: FlowItem should give access to Panel's header-leading-content slot #958

Closed
asangma opened this issue May 6, 2020 · 7 comments
Assignees
Labels
4 - verified enhancement New feature request for an existing component
Milestone

Comments

@asangma
Copy link
Contributor

asangma commented May 6, 2020

Description

Right now, in FlowItem, we are taking over Panel’s 'header-leading-content' slot with the back button when there are more than 1 FlowItem’s in a Flow.

What do y’all think about retaining access to Panel’s header-leading-content slot available in FlowItem? We’d add the back-button as it’s own thing (i.e. not using a slot) or just “overload” the header-leading-content slot in Panel.

Acceptance Criteria

No breaking changes.

Relevant Info

LayerSwitcher and future possibilities.

Which Component

FlowItem and Panel

Example Use Case

re: LayerSwitcher
Right now, Kevin will be using FlowItem’s menu-actions slot to add an Action to invoke the "layer switcher". This will work, but there might be design advantages to having the trigger on in the leading area:

  • There may be cases where both the back button and a leading action might be needed
  • The trigger can be a bit far from the title if the title is short.
  • Other things...
@asangma asangma added enhancement New feature request for an existing component question Further information is requested 0 - new labels May 6, 2020
@asangma asangma self-assigned this May 6, 2020
@driskull
Copy link
Member

driskull commented May 6, 2020

There may be cases where both the back button and a leading action might be needed

I would say just use the center slot header-content

@asangma
Copy link
Contributor Author

asangma commented May 6, 2020

Can they do that in FlowItem?

@driskull
Copy link
Member

driskull commented May 6, 2020

Can they do that in FlowItem?

Not currently, we only allow a string for that right now. We could add another slot.

@asangma
Copy link
Contributor Author

asangma commented May 6, 2020

I'll add a bullet to our sync.

@asangma asangma added 1 - assigned and removed 0 - new question Further information is requested labels May 11, 2020
@asangma asangma added this to the Marceline milestone May 11, 2020
asangma added a commit that referenced this issue May 11, 2020
asangma added a commit that referenced this issue May 11, 2020
asangma added a commit that referenced this issue May 11, 2020
asangma added a commit that referenced this issue May 12, 2020
…alcite-panel

* preliminary addition

* Updated slot name. (#958)

* Added test for leading-actions slot. (#958)

* added new slot example to demo

* added overloaded slot example

* Moved class to CSS const. (#958)

* Added e2e for empty leading-actions. (#958)

* Added additional e2e test. (#958)
@asangma asangma assigned kat10140 and unassigned asangma May 12, 2020
@asangma
Copy link
Contributor Author

asangma commented May 12, 2020

@kat10140 Easiest way to test this one is to inspect "Item Three" and "Item Two" in demos/flow/basic.html.
image
Bill helps.

@kat10140
Copy link
Contributor

Looks like the back button (calcite-action) is using that slot, if that's what i'm looking for?

@kat10140
Copy link
Contributor

VURF!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4 - verified enhancement New feature request for an existing component
Projects
None yet
Development

No branches or pull requests

3 participants