Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

Enhancement: ActionPad. Add horizontal orientation #967

Closed
asangma opened this issue May 8, 2020 · 6 comments
Closed

Enhancement: ActionPad. Add horizontal orientation #967

asangma opened this issue May 8, 2020 · 6 comments
Assignees
@kat10140
Labels
4 - verified enhancement New feature request for an existing component
Milestone
Marceline

Comments

@asangma
Copy link
Contributor

asangma commented May 8, 2020

Description

Add a property that will allow users to set the orientation of the ActionPad to horizontal.

Acceptance Criteria

image
image

Relevant Info

| vs –

Which Component

ActionPad and ActionGroup

Example Use Case

Toolbars for table editing or chart configuring.

cc @driskull
@asangma asangma added enhancement New feature request for an existing component 1 - assigned labels May 8, 2020
@asangma asangma added this to the Lumpy Space Princess milestone May 8, 2020
@asangma asangma self-assigned this May 8, 2020
asangma added a commit that referenced this issue May 8, 2020
@asangma
ActionPad. Added horizontal mode and added orientation to interfaces. (…
b49137d 
…#967)
@driskull
Copy link
Member

driskull commented May 8, 2020

Would this ever make it to the action-bar?

@driskull
Copy link
Member

driskull commented May 8, 2020

@asangma @jcfranco can you help name this property?

We could go with:

  • layout of horizontal/vertical but we already have a deprecated layout property so this would be a breaking change.
  • orientation of portrait/landscape or horizontal/vertical?
  • direction of row/column or horizontal/vertical. May sound too similar to dir attribute?

My vote would be toward layout or direction

layout is used here: https://github.com/Esri/calcite-components/blob/ad9ca1559f54326e66d47619cb78f3f9f4174547/src/components/calcite-radio-group/calcite-radio-group.tsx#L87

@jcfranco
Copy link
Member

jcfranco commented May 8, 2020

I like layout and it's also the consistent option.

@driskull
Copy link
Member

driskull commented May 8, 2020

Ok cool. We can talk about it at the next meeting. I could remove all deprecated things and we would be at V 6.0

@driskull
Copy link
Member

driskull commented May 8, 2020 •
edited
Loading

Decision was to use layout, remove all deprecations, and do a major release.

asangma added a commit that referenced this issue May 12, 2020
@asangma
conflict resolution. Updated action-pad and action-pad-group to use l…
c703f77 
…ayout (#967)
asangma added a commit that referenced this issue May 12, 2020
@asangma
Added e2e layout tests. (#967)
c00311f
@asangma asangma mentioned this issue May 12, 2020
Merged
asangma added a commit that referenced this issue May 13, 2020
@asangma
Removed layout from action-group and associated styles and e2e. (#967)
f5956fb
asangma added a commit that referenced this issue May 13, 2020
@asangma
Added container and RTL stuff and updated related styles. (#967)
57f326a
asangma added a commit that referenced this issue May 13, 2020
@asangma
Removed unnecessary selector. (#967)
868215a
asangma added a commit that referenced this issue May 14, 2020
@asangma
feat(action-pad): add horizontal layout
faf319b 
* ActionPad. Added horizontal mode and added orientation to interfaces. (#967)

* cool

* Added e2e layout tests. (#967)

* Removed layout from action-group and associated styles and e2e. (#967)

* Added container and RTL stuff and updated related styles. (#967)

* Removed unnecessary selector. (#967)
@asangma asangma assigned kat10140 and unassigned asangma May 14, 2020
@kat10140
Copy link
Contributor

kat10140 commented Jun 5, 2020

verf!

@kat10140 kat10140 closed this as completed Jun 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kat10140 kat10140

Labels
4 - verified enhancement New feature request for an existing component
Projects
None yet
Milestone
Marceline
Development

No branches or pull requests
4 participants
@jcfranco @driskull @asangma @kat10140