Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

add pre-select logic on componentDidLoad #305

Merged
merged 1 commit into from
Sep 30, 2019

Conversation

pr3tori4n
Copy link
Contributor

Related Issue: #274

Summary

  • There's some strange behavior happening in Adelheide's environment. Perhaps it's Maquette but the connectedCallback() for pickList is firing before the pick-list-items render.
    So in order to get the pre-selection working I've had to move that logic to componentDidLoad.
  • I've left it in setUpItems so it runs when the mutation observer callback fires. This means it gets called twice on first load but the Map prevents duplicate entries, so its ok. Could possibly clean this up more.

@pr3tori4n pr3tori4n self-assigned this Sep 26, 2019
@pr3tori4n pr3tori4n added the bug Something isn't working label Sep 26, 2019
Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🌮 👍

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Aside, do you have a repro case for the original issue?

@pr3tori4n pr3tori4n merged commit 814346b into master Sep 30, 2019
@pr3tori4n pr3tori4n deleted the hrobbins/picklist-preselect-take2-274 branch September 30, 2019 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants