fix(block): use CSS grid to improve header layout #895

jcfranco · 2020-03-26T18:04:26Z

Related Issue: #849

Summary

This updates Block to use CSS grid for its layout to avoid an issue where a control may flow outside its container.

driskull

Looks good. as long as @asangma approves :)

src/components/calcite-block/calcite-block.scss

…der-layout

jcfranco · 2020-03-30T15:30:13Z

as long as @asangma approves :)

Whoops, I got trigger happy. 😄 @asangma can you review this when you get a chance?

Issue #849: Use CSS grid to improve block header layout.

34a0c75

jcfranco added this to the James Baxter milestone Mar 26, 2020

jcfranco self-assigned this Mar 26, 2020

Tidy up.

823440d

jcfranco marked this pull request as ready for review March 27, 2020 23:12

jcfranco requested a review from a team as a code owner March 27, 2020 23:12

jcfranco assigned driskull and asangma Mar 27, 2020

jcfranco requested review from driskull and asangma March 27, 2020 23:12

jcfranco unassigned driskull and asangma Mar 27, 2020

jcfranco added the enhancement New feature request for an existing component label Mar 27, 2020

driskull approved these changes Mar 27, 2020

View reviewed changes

src/components/calcite-block/calcite-block.scss Show resolved Hide resolved

jcfranco added 3 commits March 27, 2020 18:03

Tweak grid positioning for header.

81faa37

Merge branch 'master' into jcfranco/849-use-grid-to-improve-block-hea…

9f0f74e

…der-layout

Merge branch 'master' into jcfranco/849-use-grid-to-improve-block-hea…

2483d5b

…der-layout

jcfranco merged commit 2250249 into master Mar 28, 2020

jcfranco deleted the jcfranco/849-use-grid-to-improve-block-header-layout branch March 28, 2020 01:31