-
Notifications
You must be signed in to change notification settings - Fork 10
fix(block-section): added rtl check and css #962
Conversation
cc @AdelheidF |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Was the CSS needed already there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
src/demos/block/basic.html
Outdated
@@ -90,6 +90,18 @@ <h3>Header + content (collapsible)</h3> | |||
<img alt="demo" src="https://placeimg.com/640/480/nature" /> | |||
</calcite-block-section> | |||
</calcite-block> | |||
|
|||
<h3>With sections</h3> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be <h2>Header + content (sections w/ switch)</h2>
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh yeah.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated.
Related Issue: #957
Summary
Add
calcite--rtl
to BlockSection.This CSS class on Block wasn't affecting BlockSection.