Skip to content
This repository has been archived by the owner on Jun 29, 2023. It is now read-only.

fix(block-section): added rtl check and css #962

Merged
merged 4 commits into from
May 7, 2020

Conversation

asangma
Copy link
Contributor

@asangma asangma commented May 6, 2020

Related Issue: #957

Summary

Add calcite--rtl to BlockSection.
This CSS class on Block wasn't affecting BlockSection.

@asangma asangma added this to the Lumpy Space Princess milestone May 6, 2020
@asangma asangma requested a review from jcfranco May 6, 2020 23:09
@asangma asangma requested a review from a team as a code owner May 6, 2020 23:09
@asangma asangma self-assigned this May 6, 2020
@asangma
Copy link
Contributor Author

asangma commented May 6, 2020

cc @AdelheidF

Copy link
Member

@driskull driskull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Was the CSS needed already there?

Copy link
Member

@jcfranco jcfranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -90,6 +90,18 @@ <h3>Header + content (collapsible)</h3>
<img alt="demo" src="https://placeimg.com/640/480/nature" />
</calcite-block-section>
</calcite-block>

<h3>With sections</h3>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be <h2>Header + content (sections w/ switch)</h2>?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh yeah.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

@asangma asangma merged commit 13483a8 into master May 7, 2020
@asangma asangma deleted the asangma/block-section-switch-rtl-957 branch May 7, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants