-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
calcite-input: pass through native input attributes #4079
Comments
@macandcheese @jcfranco can we triage this to the next sprint? |
…ccept, multiple, pattern (#5807) **Related Issue:** #4079 ## Summary Adds native input attributes: - [multiple](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/multiple) to `calcite-input` for the types specified on MDN - [accept](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/accept) to `calcite-input` for the types specified on MDN - [pattern](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/pattern) to `calcite-input-text` and `calcite-input` for the types specified on MDN - [autocomplete](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete) to `calcite-input-number`, `calcite-input-text`, and `calcite-input` for the types specified on MDN ## Note just saw on MDN after committing that Safari may not support `autocomplete`: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/autocomplete#browser_compatibility Should I remove it from the PR? <!-- Please make sure the PR title and/or commit message adheres to the https://www.conventionalcommits.org/en/v1.0.0/ specification. Note: If your PR only has one commit and it is NOT semantic, you will need to either a. add another commit and wait for the check to update b. proceed to squash merge, but make sure the commit message is the same as the title. This is because of the way GitHub handles single-commit squash merges (see zeke/semantic-pull-requests#17) If this is component-related, please verify that: - [ ] feature or fix has a corresponding test - [ ] changes have been tested with demo page in Edge --- If this is skipping an unstable test: - include info about the test failure - submit an unstable-test issue by [choosing](https://github.com/Esri/calcite-components/issues/new/choose) the unstable test template and filling it out -->
Installed and assigned for verification. |
Verified @benelan Seeking your expertise 🧠 for verifying the
|
My understanding is we have a post v1 epic to improve form validation, and for now users will still need JS like you mentioned. Here's an example: cc @driskull in case I'm wrong about that. I can another stab at it if so. For autocomplete you have to have it turned on in your browser and have saved info. This works for me: |
Awesome, thanks for your expertise! Was missing the Everything looks great in Marking as verified, since form validation will come later (and as long as JS is expected for
|
@macandcheese why do we have this issue listed on confluence in the Next section here: https://confluencewikidev.esri.com/display/Calcite/New+Web+Components |
@yelenakreyndel opened a new issue for tracking, will update Confluence: #6545 |
Repurposing this issue to add all of the native input attributes that should be passed through.
Description
The
accept
attribute restricts the type of files that can be selected when an input has the typefile
. It would be useful to have this attribute available on calcite-input.Acceptance Criteria
The
accept
property is passed down from thecalcite-input
into the internalinput
.Relevant Info
MDN docs for this attribute: https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/accept
Which Component
calcite-input
Example Use Case
Profile image upload:
The text was updated successfully, but these errors were encountered: