Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination: numberingSystem and lang are only respected when groupSeparator prop is present #5648

Closed
geospatialem opened this issue Oct 26, 2022 · 2 comments
Closed

Pagination: numberingSystem and lang are only respected when groupSeparator prop is present #5648

geospatialem opened this issue Oct 26, 2022 · 2 comments
Assignees
@geospatialem
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. i18n-l10n issues dealing with internationalization/localization
Milestone
2023 January Prio...

Comments

@geospatialem
Copy link
Member

Actual Behavior

The component will only render a specified numberingSystem and lang when the groupSeparator prop is used on the component.

image

Expected Behavior

The component should render the specified numberingSystem and lang when defined, regardless of the groupSeparator prop.

Reproduction Sample

https://codepen.io/geospatialem/pen/ZEREoZV

Reproduction Steps

  1. Open the sample
  2. Observe the first example works as-expected when the groupSeparator prop is present
  3. Observe the second example renders the numbers in "en" when the groupSeparator prop is not present

Reproduction Version

next.611

Relevant Info

Related to work performed on numberingSystem added via #4893 and #5259.

Regression?

No response

Esri team

Calcite (dev)
@geospatialem geospatialem added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. i18n-l10n issues dealing with internationalization/localization labels Oct 26, 2022
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Oct 26, 2022
@geospatialem geospatialem mentioned this issue Oct 26, 2022
Closed
8 tasks
@benelan benelan added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Oct 26, 2022
@benelan benelan self-assigned this Oct 26, 2022
@benelan benelan added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 29, 2022
@benelan benelan mentioned this issue Nov 29, 2022
Merged
benelan added a commit that referenced this issue Nov 29, 2022
@benelan
fix(pagination): numberingSystem and lang properties work without gro…
b21c5d0 
…upSeparator (#5828)

**Related Issue:** #5648

## Summary
`calcite-pagination` was only formatting (localizing) the page numbers
when the groupSeparator property was set to `true`. Now
lang/numberingSystem work correctly with or without groupSeparator
<!--

Please make sure the PR title and/or commit message adheres to the
https://www.conventionalcommits.org/en/v1.0.0/ specification.

Note: If your PR only has one commit and it is NOT semantic, you will
need to either

a. add another commit and wait for the check to update
b. proceed to squash merge, but make sure the commit message is the same
as the title.

This is because of the way GitHub handles single-commit squash merges
(see zeke/semantic-pull-requests#17)

If this is component-related, please verify that:

- [ ] feature or fix has a corresponding test
- [ ] changes have been tested with demo page in Edge

---

If this is skipping an unstable test:

- include info about the test failure
- submit an unstable-test issue by
[choosing](https://github.com/Esri/calcite-components/issues/new/choose)
the unstable test template and filling it out

-->
@benelan benelan added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 29, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@benelan benelan removed their assignment Nov 29, 2022
@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 1, 2022
@geospatialem
Copy link
Member Author

Verified on next.650.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. i18n-l10n issues dealing with internationalization/localization
Projects
None yet
Milestone
2023 January Priorities
Development

No branches or pull requests
2 participants
@geospatialem @benelan